Skip to content

chore!: regenerate protobuf code with an example - #65

Merged
nyurik merged 1 commit into
mainfrom
gen-as-example
Nov 7, 2026
Merged

nyurik merged 1 commit into
mainfrom
gen-as-example

Conversation

@nyurik

@nyurik nyurik commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Replace build.rs with examples/codegen.rs, run by just update-generated, so no build runs protoc, even with --all-features. buffa-build becomes a dev-dependency, and the codegen feature is removed.

CI installs protoc only for just codegen-check; the coverage, release-plz and gungraun jobs no longer need it. Coverage ignores the example.

Replace build.rs with examples/codegen.rs, run by `just update-generated`, so no
build runs protoc, even with --all-features. buffa-build becomes a dev-dependency,
and the `codegen` feature is removed.

CI installs protoc only for `just codegen-check`; the coverage, release-plz and
gungraun jobs no longer need it. Coverage ignores the example.
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

Copy/paste detection

ℹ️ Found 3 clones (0 new compared to origin/main) with 22 duplicated lines — 0.38% of 5781 lines in 40 files.

Clones
New Lines Tokens Location Duplicated in
9 61 benches/common/encode.rs:299-307 src/geom_writer.rs:151-159
7 58 src/reader/feature.rs:202-208 src/reader/feature.rs:213-219
6 66 src/writer.rs:594-599 src/writer.rs:607-612

@nyurik
nyurik enabled auto-merge (squash) November 7, 2026 08:18
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (7d6602f) to head (8bbadd5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   99.21%   99.20%   -0.01%     
==========================================
  Files          12       11       -1     
  Lines        2033     2018      -15     
==========================================
- Hits         2017     2002      -15     
  Misses         16       16              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nyurik
nyurik merged commit 8ee0411 into main Nov 7, 2026
10 checks passed
@nyurik
nyurik deleted the gen-as-example branch November 7, 2026 08:21
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

fast-mvt encode/decode — CPU instruction counts

fast-mvt's own encode/decode instruction counts, measured by gungraun under Valgrind/Callgrind — one-shot and deterministic, so these are exact (the mvt/mvt-reader/tinymvt comparison cases run only locally via just bench-cpu, not in CI). A diff vs. the PR base appears once the base branch also carries the gungraun bench. Informational only; this never fails CI.

Results
decoder_cpu::decoder_cpu::decode fast:(setup(Dec :: Fast))
  Baselines:                                              |base
  Instructions:                                 1583913792|1583913792           (No change)
  L1 Hits:                                      2284056290|2284056704           (-0.00002%) [-1.00000x]
  LL Hits:                                         1161100|1160717              (+0.03300%) [+1.00033x]
  RAM Hits:                                        8286330|8286299              (+0.00037%) [+1.00000x]
  Total read+write:                             2293503720|2293503720           (No change)
  Estimated Cycles:                             2579883340|2579880754           (+0.00010%) [+1.00000x]

Gungraun result: Ok. 1 without regressions; 0 regressed; 2 filtered; 1 benchmarks finished in 62.9851s

encoder_cpu::encoder_cpu::encode fast:(setup(Enc :: Fast))
  Baselines:                                              |base
  Instructions:                                   91052072|91042765             (+0.01022%) [+1.00010x]
  L1 Hits:                                       127618279|127607680            (+0.00831%) [+1.00008x]
  LL Hits:                                          173513|173190               (+0.18650%) [+1.00187x]
  RAM Hits:                                         315125|315119               (+0.00190%) [+1.00002x]
  Total read+write:                              128106917|128095989            (+0.00853%) [+1.00009x]
  Estimated Cycles:                              139515219|139502795            (+0.00891%) [+1.00009x]
encoder_cpu::encoder_cpu::encode fast_owned:(setup(Enc :: FastOwned))
  Baselines:                                              |base
  Instructions:                                  156913750|156923505            (-0.00622%) [-1.00006x]
  L1 Hits:                                       219863828|219878477            (-0.00666%) [-1.00007x]
  LL Hits:                                          664226|663548               (+0.10218%) [+1.00102x]
  RAM Hits:                                         328311|328318               (-0.00213%) [-1.00002x]
  Total read+write:                              220856365|220870343            (-0.00633%) [-1.00006x]
  Estimated Cycles:                              234675843|234687347            (-0.00490%) [-1.00005x]

Gungraun result: Ok. 2 without regressions; 0 regressed; 4 filtered; 2 benchmarks finished in 8.47481s

@nyurik nyurik mentioned this pull request Nov 8, 2026
nyurik added a commit that referenced this pull request Nov 8, 2026
## 🤖 New release

* `fast-mvt`: 0.7.1 -> 0.7.2 (⚠ API breaking changes)

### ⚠ `fast-mvt` breaking changes

```text
--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/feature_missing.ron

Failed in:
  feature codegen in the package's Cargo.toml
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.7.2](v0.7.1...v0.7.2) -
2026-11-08

### Other

- [**breaking**] regenerate protobuf code with an example
([#65](#65))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant