Skip to content

The Nix pipelines #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

The Nix pipelines #1573

wants to merge 6 commits into from
+278 −0

Conversation

Sk7Str1p3
Copy link
Contributor

This pull request supersedes #1549 with much better approaches.
Features:

  • Development shell
  • Automatic checks (just ran all checks and it found 3 vulnerabilities in gix, wth?)
  • Incremental builds - download ready crates from cachix/garnix
  • Automatic flake.lock update (not sure if this even works?)

this can also be used in CI for much more powerful checks

Sk7Str1p3 added 6 commits May 4, 2025 19:04
@Sk7Str1p3
crane: init
8c71204
@Sk7Str1p3
direnv: init
7928e44
@Sk7Str1p3
workflow: attempt on automatic flake update
0211e90
@Sk7Str1p3
flake: fixes
77afd70 
> add nix tools to devShell (rust-required stuff provided by default)

> add build dependencies

> add build profiles
@Sk7Str1p3
flake: binary caches
f2b9f7b
@Sk7Str1p3
crane: additionals init
b7d3fe6
@Sk7Str1p3
Copy link
Contributor Author

By the way, as I am newbie to rust ecosystem, I suppose I did some bad configuration in toml configs. If you think so, let me know.

spenserblack
spenserblack reviewed May 5, 2025
View reviewed changes
.cargo/audit.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work in the sandbox

What happens in the sandbox? Does it fail to send HTTP requests to crates.io?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not checked (this is crane generated defaults) but I suppose yes it fails

taplo.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting up TOML formatting sounds good to me, but TBH I think this can go in a separate PR. That way we can get TOML formatting merged in faster while we still discuss flake.

flake.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to research flake later, but could you discuss the pros of tracking the lock file in the repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same pros of tracking cargo.lock in repository - to be sure the shell will be SAME, and to be sure it is going to behave same way anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack left review comments

@o2sh o2sh Awaiting requested review from o2sh o2sh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sk7Str1p3 @spenserblack