Repository navigation
MISP Extension definitions - #84
Merged
Merged
Conversation
Four STIX 2.1 extensions (MISP Property, Attribute, Object and Galaxy Cluster) carrying the MISP content no standard STIX object or property holds. This repository is their canonical home; misp-stix ships copies.
Markdown styled after the STIX 2.1 Markdown specification.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MISP Extension definitions
Summary
Adds the MISP Extensions: a suite of four STIX 2.1 extensions carrying the MISP content that no standard STIX object or property holds. They replace the custom syntax (
x-misp-*objects,x_misp_*properties) that the MISP-STIXconverter (misp-stix) used until now. The MISP Project identity (
identity--55f6ea65-aa10-4c5a-bf01-4f84950d210f) creates all four.5ece67eaproperty-extensionc1f2c0fanew-sdo(misp-attribute)a093107bnew-sdo(misp-object)573a76d8new-sdo(misp-galaxy-cluster)The layout follows
incident-ef7: the main extension sits at the root of the spec directory, and each new SDO has its own subdirectory. The schema$ids and theschemaproperty of each extension definition point to this repository,which becomes the canonical home. misp-stix ships copies and will point them here before it releases them.
The spec document is Markdown, styled after the Markdown edition of the STIX 2.1 specification. The AsciiDoc workflows only pick up
*/*.adoc, so the document is not on the Pages index and gets no CI validation. It renders in theGitHub tree.
Evidence
stix2-validator 3.3.2:
'^(?!(extension_type|opinion|author_ref|attachment|filename|url|malware_sample|original_names|windows_pebinary_ext|values)$)[a-z][a-z0-9_]{2,249}$'
```
After: the 8 examples, as committed, are all
[+] STIX JSON: Valid, and the validator applies each of the four extension schemas. The 4 published extension definitions are `[+] STIX JSON: Valid` with no warnings, and identical totheir copies in the examples.
The examples raise 12 best-practice warnings and no errors. They are converted from misp-stix test events, which explains the warnings:
Merge Danger
Door: one-way
Merging publishes four extension definition ids, their
schemaURL and the schema$ids. misp-stix will write them into every bundle it exports, so they cannot move afterwards. A change to a definition needs a newmodified, and abreaking schema change needs a new version. Reverting this PR would break those references, not unpublish them.
Blast Radius: additive
The PR adds new files only. It changes no existing object, schema or spec, and adds no
mapping.csvrow. CI ignores the new files: the AsciiDoc workflows glob*/*.adoc, and the daily CVE job only writes whatmapping.csvlists. TheMISP Project identity is not added to
objects/identity/; misp-stix ships it, and several other creators of published extension definitions are also absent from that directory.