Handling of cross-service references#359
Draft
HeikoTheissen wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal: Expose external entities as abstract objects:
odata-openapi/tools/tests/ref-error.openapi3.json
Lines 3488 to 3491 in 34c1763
To generate these additional
/components/schemas, the XSL transformations needs to select external type references, which is not straightforward with the current code. With the approach of #291, this can be done asodata-openapi/tools/V4-CSDL-to-OpenAPI.xsl
Lines 587 to 594 in 9d87d8e
odata-openapi/tools/V4-CSDL-to-OpenAPI.xsl
Lines 1459 to 1463 in 9d87d8e