Skip to content

Render nodeSelector without whitespace #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jess-belliveau
Copy link

Noted during a recent update of our component that when setting the nodeSelector value the manifests are rendered with a newline.

Providing:

        nodeSelector:
          key: value

yeilds the following in rendered manifests:

      nodeSelector:
        
        key: value

@pierluigilenoci
Copy link
Contributor

@jess-belliveau The PR also lacks the chart bump and the message for ArtifactHub.

@jess-belliveau
Copy link
Author

@pierluigilenoci updated 👍

pierluigilenoci
pierluigilenoci previously approved these changes May 2, 2025
@pierluigilenoci pierluigilenoci requested a review from tuunit May 2, 2025 11:27
@jess-belliveau
Copy link
Author

@pierluigilenoci - not sure what you would want to do with the conflict here. Does the chart.yaml reflect the latest PR merged, so I should update and resolve the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants