You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Lightbox is not a React Navigation modal — it's a raw Modal from React Native (wrapped inside react-native-image-viewing). This changes the safe-area behavior compared to navigation-managed modals:
Platform
Who applies safe area?
iOS
No automatic insets in full-screen custom modals → you must add them yourself
Android (API 30+ edge-to-edge)
The library internally uses SafeAreaView or system insets → safe area is already applied
De huidige implementatie gebruikt SafeAreaView van React Native, en die doet precies wat nodig is: insets op iOS en niets op Android. Als we SafeAreaView/useSafeAreaInsets van react-native-safe-area-context gaan gebruiken, moeten we die enkel toepassen op iOS. Dat zou mijn case fixen.
Maar van de mix van drie repo's, twee platforms en twee safe-area views word ik behoorlijk confuus. Laten we eerst maar de updates de deur uit doen, dan kijk ik hier op een rustig moment nog eens naar.
Maar van de mix van drie repo's, twee platforms en twee safe-area views word ik behoorlijk confuus. Laten we eerst maar de updates de deur uit doen, dan kijk ik hier op een rustig moment nog eens naar.
Groot gelijk 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for https://github.com/observation/app/issues/967