-
Notifications
You must be signed in to change notification settings - Fork 0
add mvp #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mvp #1
Conversation
|
Keeping this repo private until this is integrated into https://github.com/observatorycontrolsystem/ocs_example I've tested this using Just change the datetime to just before the first observation. |
|
observatorycontrolsystem/ocs_example#11 integrates this into ocs_example |
mgdaily
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good! A few comments.
I also think perhaps some docstrings and/or inline comments could increase clarity inside of virtual_site.py. I like the logging that's there, but since it's a demonstrative piece of code, it'd be nice to have it annotated just a little bit.
jnation3406
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I agree with Matt that more inline comments, and README description would be nice just since it's meant to teach them. You could even link to Matt's documentation pages that reference the parts of this process.
No description provided.