Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Set minimum version for nlohmann_json to 3.11 #1262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Oct 15, 2024

Description

We know this is the minimum version that we require, so we can just fail during configure if somehow an older version is found.

Motivation and Context

See:

Although we no longer support Ubuntu 22.04 for building or running OBS Studio, we can make the dependency requirement here more obvious at configure time.

How Has This Been Tested?

Tested OS(s):

  • Windows 11

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Other Enhancement (anything not applicable to what is listed)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from tt2468 October 15, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant