Repository navigation
Conversation
mefyl
marked this pull request as draft
October 28, 2026 09:43
mefyl
force-pushed
the
feat/rpc-client-progress-jobs
branch
3 times, most recently
from
October 28, 2026 10:16
266736f to
7cdbebc
Compare
mefyl
marked this pull request as ready for review
October 28, 2026 10:18
Signed-off-by: mefyl <quentin@tarides.com>
mefyl
force-pushed
the
feat/rpc-client-progress-jobs
branch
from
October 29, 2026 14:21
7cdbebc to
3eb40cf
Compare
3 tasks done
Member
|
What about total action time and build start? Otherwise you won't be able to recreate the non-rpc progress we have. |
Collaborator
Author
|
Given the discussion, it seems clear we don't want anything but exactly the same status line, squashing this into #16819 |
An error occurred while trying to automatically change base from
feat/rpc-client-progress
to
main
October 30, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On top of reporting the progress when building over RPCs, also report the number of jobs.
Example status line output:
Related Issue and Motivation
Including the jobs count makes the status line the same as when building without RPC, which I think is neat. It requires however quite a bit of additional plumbing, which might not be worth it, hence the separate PR.
This approach changes the progress reporting protocol to include running jobs, which is debatable. An alternative would be to use a second poll subscription with the existing jobs monitoring, which is less invasive but heavier i/o wise.
Checklist