Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DIMA: 2026092200119340446
Summary
Anonymous requests with a public-route suffix in the query string could bypass Dashboard authentication and panic while listing tenants.
Solution Description
Restrict anonymous access to the five registered route/method combinations. Validate session identity and expiration, reject missing tenant-list identity before Kubernetes access, and preserve HTTP 401 through the handler.
Regression tests cover query/path suffixes, encoded queries, incorrect methods, public routes, valid and malformed sessions, cookie refresh, and tenant-list error propagation.
Validation
9201b033b851b74b5c416f4f0b4417b8e8736c48; fix:a7f299969656600c897e403db9ba511a967759cd.go test -count=1 ./internal/dashboard/middleware ./internal/dashboard/business/oceanbase ./internal/dashboard/handler -run 'TestLoginRequired|TestListAll', also with-race, using isolated local kubeconfig/RBAC fixtures.go vetfor the three affected packages andmake dashboardpassed.obcluster_test.go:264affinity andobcluster_usage_test.go:88available CPU), reproduced on the unchanged baseline.