Add DeepSeek V3.2 DSML format support with synthetic template#17
Merged
Add DeepSeek V3.2 DSML format support with synthetic template#17
Conversation
DeepSeek V3.2 doesn't provide a Jinja template but uses a custom Python encoding (encoding_dsv32.py) with DSML format for tool calls: <｜DSML｜parameter name="key" string="true">value</｜DSML｜parameter> Changes: - Simplify argument needle detection to use broader `"argument_needle"` pattern which matches both JSON keys and DSML attribute values - Add support for local .jinja files in fetch script (for synthetic templates) - Add synthetic-deepseek-v3.2-dsml.jinja replicating V3.2's Python encoding - Add capability test for the synthetic template 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
@ochafik I have already write a jinja template for deepseek v3.2 (with the help of claude, but not fully vibe coding), see: https://github.com/hksdpc255/llama.cpp/blob/c9315a3c739167e150202870fb5ff6093a4b7162/models/templates/DeepSeek-V3.2.jinja. I'm not sure if it is better than yours. Which one should we use? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for DeepSeek V3.2's DSML (Domain Specific Markup Language) format, superseeds #11 (cc/ @hksdpc255)
DeepSeek V3.2 doesn't provide a Jinja template but uses a custom Python encoding with DSML format:
Changes
"argument_needle":,="argument_needle") to broader"argument_needle"pattern which matches both JSON keys and DSML attribute values.jinjafiles in MODEL_IDS (for synthetic test templates)synthetic-deepseek-v3.2-dsml.jinjareplicating V3.2's Python encoding logic (fromencoding_dsv32.py)Test plan
supports_tool_calls: true,requires_object_arguments: true)Closes #11
🤖 Generated with Claude Code