Fix slow tokenize() on Windows/MSVC
#25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing ggml-org/llama.cpp#18353 and
test-chatis unbearably slow on MSVC (always has been).The cause is MSVC's
std::regexengine. Theregex_search()calls take a considerable amount of time during tokenization. I added some profiling and tested with the Apertus-8B-Instruct.jinja template:18.2s to parse.
This PR adds
std::regex_constants::match_continuousto theregex_search()calls. This flag instructs the regex engine to only match from the start of the iterator, which aligns with the existingmatch.position() == 0check.0.12s, much better.