WIP: refactor exception handling #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alokgoswami-ag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alokgoswami-ag
changed the title
alokgoswami-ag
changed the title
alokgoswami-ag
force-pushed
the
refactor-exception-handling
branch
from
2bb7328 to
f545e5c
Compare
alokgoswami-ag
force-pushed
the
refactor-exception-handling
branch
from
f545e5c to
f86afaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created function wrappers in monitor_compat.py for each public function in monitor.py: they call the underlying function in a try block, catch any exceptions, and convert them via a helper _err_str_from_exc() into the legacy error string or tuple.
Module-level globals PROW_URL and final_job_list are proxied so legacy callers that set/read them still work.
The module includes a getattr fallback so any attribute not explicitly wrapped is forwarded to monitor.py, preserving full API coverage.
No breaking changes: monitor.py still behaves as before; legacy calls via monitor_compat.py behave as before in terms of error returns.