-
Notifications
You must be signed in to change notification settings - Fork 194
Propagate arity between compilation units #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vouillon, feel free to comment, review and even commit the branch. |
ffe3e43
to
c7c009b
Compare
ce02188
to
f8138d0
Compare
b17b2f0
to
1ed2368
Compare
14fe546
to
3821d45
Compare
@vouillon, I think we could merge this before we have the support merged inside dune. |
a160212
to
53d94b5
Compare
It increases to the time to build the toplevel in whole program compilation by ~10%. But we don't benefit from shapes in such case. |
The following command spends a lot of time in
|
99a19f4
to
b3a69be
Compare
@rickyvetter, the new/updated build rules should be much easier to integrate. |
eed6b65
to
cc7fa2d
Compare
- Propagate shape information through the flow analysis
This reverts commit 9c0692f8af4d6fafdf0fc428f820cc9753897cc4.
Fixes #550
//# shapes:
) inside the generated js and can be read back if explicitly requested (with the--load-shape FILE.cma.js
)TODOs:
yesno, adding support in dune was too annoying.bothloading shapes need to be explicit.