Closure optimization: omit code pointer when not used #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
closure-optim
branch
2 times, most recently
from
d9ef933 to
c789e10
Compare
hhugo
reviewed
Jul 8, 2025
|
compilation time for fiat-crypto increases from 128s to 135s. Do you know where it's spent ? |
I think |
hhugo
reviewed
Jul 21, 2025
| "CALL others:%b known:%d@." | ||
| others | ||
| (Var.Set.cardinal known) | ||
| with Invalid_argument _ -> ()) |
hhugo
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of memory allocated. But I think this also allows Binaryen to make more optimizations, since it becomes clear that the function is only called from known places.