fs_fake: implement rename #2080
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
reviewed
Jul 21, 2025
| @@ -81,6 +81,17 @@ class MlFakeDevice { | |||
| } | |||
| } | |||
|
|
|||
| rename(oldname, newname) { | |||
| if (this.exists(newname)) | |||
| caml_raise_sys_error(this.nm(newname) + " : file already exists"); | |||
There was a problem hiding this comment.
This is not the expected behavior.
The doc says
If a file named
[newpath] already exists, its contents will be replaced with those of
[oldpath].
hhugo
reviewed
Jul 21, 2025
| if (!this.exists(oldname)) | ||
| caml_raise_sys_error(this.nm(oldname) + " : no such file or directory"); | ||
| if (this.is_dir(oldname)) | ||
| caml_raise_sys_error(this.nm(oldname) + " : not a file"); |
There was a problem hiding this comment.
The doc says:
Rename a file or directory. [rename oldpath newpath] renames the
file or directory called [oldpath], giving it [newpath] as its new name,
moving it between (parent) directories if needed.
We shouldn't fail on directory.
You should probably add tests in compiler/tests-compiler/sys_fs.ml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.