Skip to content

Do not force form-data-boundary, make it fully customizable #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

Justin99b
Copy link

Some applications might require setting the boundary to a specific value, this pull request removes form-data-encoder and accepts the plain value

@octet-stream
Copy link
Owner

octet-stream commented Jun 4, 2025

Hi. Thanks for your PR. I don't mind the change, but please remove /lib content from git tracking. How it even ended up here? It is in .gitignore.

Also, can you elaborate and give me some examples? Because the spec doesn't say it should have specific values. What is your use-case that required remove of the prefix?

@Justin99b
Copy link
Author

Hey, thanks for the feedback! Im wondering why it even shows up it was ment to be only on my personal repo so i can quickly out if it worked without needing to locally reference it. I'll remove it

@Justin99b
Copy link
Author

The usecase was that im using an api which is required to not have any prefix. I cant tell you exactly why that is but its apperently important as it wasnt working haha

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72c6570) to head (da91d4e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          651       651           
  Branches        91        91           
=========================================
  Hits           651       651           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@octet-stream
Copy link
Owner

so i can quickly out if it worked without needing to locally reference it. I'll remove it

afaik you should be able to just npm install your fork and it will be compiled if I haven't removed prepare script. Don't remember if I did :D

Anyway, I have squashed your changes into one commit, because you pushed to the main branch. Sorry I lost your name in the commit, I did this for the first time and seems like git reset --soft does that.

Please send your changes via separate branch next time, thanks :)

Copy link
Owner

@octet-stream octet-stream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octet-stream octet-stream merged commit a3ab4b1 into octet-stream:main Jun 4, 2025
13 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2025
@Justin99b
Copy link
Author

Much appreciated, thanks for the great work!

@octet-stream
Copy link
Owner

No, thanks to you!

https://github.com/octet-stream/form-data-encoder/releases/tag/v4.1.0 is available on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants