-
Notifications
You must be signed in to change notification settings - Fork 13
Do not force form-data-boundary, make it fully customizable #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi. Thanks for your PR. I don't mind the change, but please remove Also, can you elaborate and give me some examples? Because the spec doesn't say it should have specific values. What is your use-case that required remove of the prefix? |
Hey, thanks for the feedback! Im wondering why it even shows up it was ment to be only on my personal repo so i can quickly out if it worked without needing to locally reference it. I'll remove it |
The usecase was that im using an api which is required to not have any prefix. I cant tell you exactly why that is but its apperently important as it wasnt working haha |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 651 651
Branches 91 91
=========================================
Hits 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
afaik you should be able to just Anyway, I have squashed your changes into one commit, because you pushed to the main branch. Sorry I lost your name in the commit, I did this for the first time and seems like Please send your changes via separate branch next time, thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Much appreciated, thanks for the great work! |
No, thanks to you! https://github.com/octet-stream/form-data-encoder/releases/tag/v4.1.0 is available on npm. |
Some applications might require setting the boundary to a specific value, this pull request removes form-data-encoder and accepts the plain value