feat(repo): consolidate Cloudflare integration PRs#7
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af43ae615c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const outDir = resolveOutDir(name); | ||
| if (outDir) { | ||
| fs.rmSync(outDir, { recursive: true, force: true }); |
There was a problem hiding this comment.
Guard recursive cleanup against unsafe outDir
When a Vite project customizes a Worker environment's build.outDir to . or a path outside the project (for example ../dist/worker), this hook resolves that path and recursively deletes it before Vite's own output-directory safeguards run. That can wipe the source tree or arbitrary parent directories during vite build; please only remove output directories that are safe children of the intended build root and never the root itself.
Useful? React with 👍 / 👎.
Summary
Consolidates the open alchemy-effect/cloudflare-tools integration PR work into one dogfood monorepo branch.
Included:
Not duplicated:
Monorepo adaptation:
Validation
Live deploy-backed Alchemy Vite provider tests were not run locally; they need Cloudflare credentials/state and should run in the secret-backed environment.