Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes account linking bugs.
Failed to fetch root DID
The account linking consumer is initialized a second time after account linking. It seems the
link-device
page is loaded a second time.The fix here is guarding the initialization call when we have a session, which prevents the account linking consumer from starting unnecessarily.
odd-app-template/src/routes/link-device/+page.svelte
Lines 58 to 60 in 435a235
Could not parse a valid private tree using the given key
The file system data root may not be available immediately after linking completes. This issue is documented in oddsdk/ts-odd#529. When this issue occurs, the result is a
Error: Could not parse a valid private tree using the given key
, but only after a reload.The fix for this issue is waiting in the account linking consumer until the data root is available (when it is a non-empty CID).
Type of change
Testing
Create a new account and link it on a second device immediately and as quickly as possible. No errors should occur and the file system should load and work as expected.