[FIX] html_editor: link popover not hidden on clicking other element #4762
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg-next, it needs to be retargeted before it can be merged. |
ged-odoo
force-pushed
the
master-mysterious-egg-next
branch
from
6e36b56 to
48edd7d
Compare
dabo-odoo
force-pushed
the
master-mysterious-egg-dabo-link-popover-not-disappearing-on-click-other-element
branch
2 times, most recently
from
abddce2 to
9930a96
Compare
…ement Before this commit clicking on certain elements with a link popover open would not cause the link popover to close. Steps to reproduce: - go to the website homepage - open the editor - click on any top menu links like Home or Contact Us - click on the user dropdwon in the topbar (usually Administrator) - the popover from the first click is still open After the change clicking anywere that's not the popover's current link will cause the popover to close.
dabo-odoo
force-pushed
the
master-mysterious-egg-dabo-link-popover-not-disappearing-on-click-other-element
branch
from
9930a96 to
e6979cf
Compare
| // Some elements can be clicked on without the selection being changed | ||
| // In those cases the overlay closing and opening must be done manually | ||
| this.addDomListener(this.editable, "click", (ev) => { |
There was a problem hiding this comment.
Hello, I think this is not the right place to fix the issue. The root cause is that when clicking some elements, the selection is not changed. Most likely, they prevented default on these elements. This influences all the selection change handlers.
For example, with the current fix, when you select text from Home button and the tool bar will popup, then you click the Administrator drop down, the toolbar stays open.
IMO, we should check why the selection change is prevented and make the fix there 🤔
Also we already have a click event listener, so if you still need to do the changes at click, you can probably move the code there :)
Before this commit clicking on certain elements with a link popover
open would not cause the link popover to close.
Steps to reproduce:
After the change clicking anywere that's not the popover's current
link will cause the popover to close.