[FIX] website: do not redirect after editing menus from the builder #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg-next, it needs to be retargeted before it can be merged. |
ged-odoo
force-pushed
the
master-mysterious-egg-next
branch
from
6e36b56 to
48edd7d
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-7
branch
from
8837af6 to
3f350ff
Compare
Steps to reproduce: - Edit a page - Click on a menu item and click on the "Edit menu" icon - Add an item and save => The iframe is reloaded, but leads to a 404 instead of staying on the same page. This is because when passing a URL to `reloadEditor`, the given string is then encoded with `encodeURIComponent`, which will append the string to the current domain. We can just leave the parameter empty.
robinlej
force-pushed
the
master-mysterious-egg-role-7
branch
from
8265a2b to
b022c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
This is because when passing a URL to
reloadEditor, the given string is then encoded withencodeURIComponent, which will append the string to the current domain. We can just leave the parameter empty.