[IMP] account: Add more visibility about the sent status of invoice #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 4, 2025
| @@ -603,6 +603,11 @@ def _sequence_year_range_monthly_regex(self): | |||
| tracking=True, | |||
| help="It indicates that the invoice/payment has been sent or the PDF has been generated.", | |||
| ) | |||
| move_sent_status = fields.Selection( | |||
| [('sent', 'Sent'), ('not_sent', 'Not Sent')], | |||
There was a problem hiding this comment.
nitpicking here but you split in multiple line for readability, also small rule of thumbs that i like:
- Use double quotes when the user see the info (so here Sent and Not Sent could be in double quotes)
- use single quotes otherwise
There was a problem hiding this comment.
Done, thanks for the review!
This commit aims to add a new column "Sent Status" to invoice list view. And a filter for "sent" invoices. task-4908901
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-add-more-visisblity-on-sent-status-alah
branch
from
982c838 to
150c827
Compare
malb-odoo
reviewed
Jul 7, 2025
| @@ -603,6 +603,11 @@ def _sequence_year_range_monthly_regex(self): | |||
| tracking=True, | |||
| help="It indicates that the invoice/payment has been sent or the PDF has been generated.", | |||
| ) | |||
| move_sent_status = fields.Selection( | |||
| [('sent', "Sent"), ('not_sent', "Not Sent")], | |||
There was a problem hiding this comment.
for the next pr's, usually we split those in mutliple line 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to add a new column "Sent Status" to invoice list view. And a filter for "sent" invoices.
task-4908901