[FIX] l10n_fr_account: show delivery date on customer invoice #4808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 4, 2025
| def _post(self, soft=True): | ||
| res = super()._post(soft) | ||
| for move in self: | ||
| if move.country_code == 'FR' and move.is_sale_document() and not move.delivery_date: |
There was a problem hiding this comment.
you can use the show_delivery_date delivery date instead of forcing this here, and we could argue that you must use the is_company_french since some country are part of France like monaco or some island 😄
Purpose ------- Comply with new French legislation requiring the delivery date to appear on customer invoices. This aims to increase transparency for buyers and meet legal obligations. Changes ------- - Added a `delivery_date` field in the invoice form for companies based in France. - Field is editable by the user and shown in the invoice header. - If no delivery date is provided, the invoice date is used as default. - Delivery date is also printed on the invoice layout (PDF report). - Aligned implementation with similar use cases in other localisations. How to test ----------- 1. Set the company country to France. 2. Go to Accounting > Customers > Invoices. 3. Open or create a customer invoice. 4. A new "Delivery Date" field should appear in the form header. 5. Leave it empty or set a specific date. 6. Save and print the invoice. 7. The delivery date should appear in the invoice header, defaulting to the invoice date if not manually set. task-4908872
baje-odoo
force-pushed
the
18.0-rd-accounting-onboarding-delivery-france-invoice-baje
branch
from
c49978e to
b34d441
Compare
malb-odoo
reviewed
Jul 7, 2025
| res = super()._post(soft) | ||
| for move in self: | ||
| if move.show_delivery_date and not move.delivery_date: | ||
| move.delivery_date = move.invoice_date or fields.Date.context_today(self) |
There was a problem hiding this comment.
if i'm not mistaken the invoice date is always filled so no need for the or, but i like the defensive programming though ahah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Comply with new French legislation requiring the delivery date to appear on customer invoices. This aims to increase transparency for buyers and meet legal obligations.
Changes
delivery_datefield in the invoice form for companies based in France.How to test
task-4908872