[IMP] l10_fr_account: show delivery date on invoice #4815
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-l10_fr-show-delivery-date-on-invoice-alah
branch
from
5252ace to
7ae4bdf
Compare
mograby3500
changed the title
malb-odoo
reviewed
Jul 4, 2025
Comment on lines
23
to
28
| @api.depends('invoice_date', 'l10n_fr_is_company_french', 'delivery_date') | ||
| def _compute_delivery_date(self): | ||
| super()._compute_delivery_date() | ||
| for move in self: | ||
| if move.invoice_date and move.l10n_fr_is_company_french and not move.delivery_date: | ||
| move.delivery_date = move.invoice_date |
There was a problem hiding this comment.
Not needed in the scope of this task, only _compute_show_delivery_date and post are enough 😄
There was a problem hiding this comment.
Deleted, thanks for the review!
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-l10_fr-show-delivery-date-on-invoice-alah
branch
from
7ae4bdf to
a0a3b6b
Compare
malb-odoo
reviewed
Jul 7, 2025
|
|
||
| def _post(self, soft=True): | ||
| for move in self: | ||
| if move.l10n_fr_is_company_french and move.is_sale_document() and not move.delivery_date: |
There was a problem hiding this comment.
if you use the field show_delivery_date you don't need to check that again 😄
New legislation in France to add delivery date on invoice. task-4908900
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-l10_fr-show-delivery-date-on-invoice-alah
branch
from
a0a3b6b to
77b7f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New legislation in France to add delivery date on invoice.
task-4908900