Skip to content

Conversation

@fdamhaut
Copy link
Contributor

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 5158912

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Oct 27, 2025

Pull request status dashboard

@fdamhaut fdamhaut force-pushed the master-style-text-rotation-flda branch from 1b6de67 to 2e88f54 Compare October 27, 2025 12:21
@fdamhaut fdamhaut force-pushed the master-style-text-rotation-flda branch from ed16251 to 0359de5 Compare October 29, 2025 09:23
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +45 to +49
interface Expect {
toBeBetween(lower: number, upper: number): ExpectResult;
toBeSameColorAs(expected: string, tolerance?: number): ExpectResult;
toBeCloseTo(expected: number, closeDigit?: number): ExpectResult;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed ?

import { CancelledReason, DispatchResult, Zone } from "../../src/types";

type DOMTarget = string | Element | Document | Window | null;
type ExpectResult = { pass: boolean; message: () => string };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Comment on lines +494 to +497
if (style.rotation) {
return style.rotation;
}
return 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return style.rotation || 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants