-
Notifications
You must be signed in to change notification settings - Fork 67
Master style text rotation flda #7376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1b6de67 to
2e88f54
Compare
Add rotation to the text style. Task-id: 5158912
ed16251 to
0359de5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| interface Expect { | ||
| toBeBetween(lower: number, upper: number): ExpectResult; | ||
| toBeSameColorAs(expected: string, tolerance?: number): ExpectResult; | ||
| toBeCloseTo(expected: number, closeDigit?: number): ExpectResult; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed ?
| import { CancelledReason, DispatchResult, Zone } from "../../src/types"; | ||
|
|
||
| type DOMTarget = string | Element | Document | Window | null; | ||
| type ExpectResult = { pass: boolean; message: () => string }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
| if (style.rotation) { | ||
| return style.rotation; | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return style.rotation || 0;

Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5158912
review checklist