-
Notifications
You must be signed in to change notification settings - Fork 69
[FIX] GridOverlay: Prevent mousedown default when selecting range #7493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rrahir
wants to merge
1
commit into
17.0
from
17.0-prevent-composer-text-selection-on-grid-selection-rar
Closed
[FIX] GridOverlay: Prevent mousedown default when selecting range #7493
rrahir
wants to merge
1
commit into
17.0
from
17.0-prevent-composer-text-selection-on-grid-selection-rar
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
Author
|
robodoo fw no |
Collaborator
|
@rrahir expected '=', got 'no'. For your own safety I've ignored everything in your entire comment. Currently available commands:
Note: this help text is dynamic and will change with the state of the PR. |
Collaborator
Author
|
robodoo fw=no |
Collaborator
|
Disabled forward-porting. |
hokolomopo
reviewed
Nov 21, 2025
When selecting a range in the grid and the composer is open, passing your selection around the composer will see its content selected as if we were actually selecting text inside the composer. This behaviour is a direct effect of the default behaviour of the mousedown event that starts the selection. Since the focus is kept on the composer at all times, the browser behaves as if we had clicked on the composer itself even if from a user point of view, it makes little sense. Task: 5344285
94a9085 to
879604f
Compare
Collaborator
LucasLefevre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Nov 28, 2025
When selecting a range in the grid and the composer is open, passing your selection around the composer will see its content selected as if we were actually selecting text inside the composer. This behaviour is a direct effect of the default behaviour of the mousedown event that starts the selection. Since the focus is kept on the composer at all times, the browser behaves as if we had clicked on the composer itself even if from a user point of view, it makes little sense. closes #7493 Task: 5344285 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

When selecting a range in the grid and the composer is open, passing your selection around the composer will see its content selected as if we were actually selecting text inside the composer.
This behaviour is a direct effect of the default behaviour of the mousedown event that starts the selection. Since the focus is kept on the composer at all times, the browser behaves as if we had clicked on the composer itself even if from a user point of view, it makes little sense.
Task: 5344285
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist