Skip to content

Conversation

@rrahir
Copy link
Collaborator

@rrahir rrahir commented Nov 19, 2025

When selecting a range in the grid and the composer is open, passing your selection around the composer will see its content selected as if we were actually selecting text inside the composer.

This behaviour is a direct effect of the default behaviour of the mousedown event that starts the selection. Since the focus is kept on the composer at all times, the browser behaves as if we had clicked on the composer itself even if from a user point of view, it makes little sense.

Task: 5344285

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 19, 2025

Pull request status dashboard

@rrahir
Copy link
Collaborator Author

rrahir commented Nov 19, 2025

robodoo fw no

@robodoo
Copy link
Collaborator

robodoo commented Nov 19, 2025

@rrahir expected '=', got 'no'.

For your own safety I've ignored everything in your entire comment.

Currently available commands:

command
help displays this help
r(eview)+ approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number> only approves the specified parents
fw=no does not forward-port this PR
fw=default forward-ports this PR normally
fw=skipci does not wait for a forward-port's statuses to succeed before creating the next one
fw=skipmerge does not wait for the source to be merged before creating forward ports
up to <branch> only ports this PR forward to the specified branch (included)
merge integrate the PR with a simple merge commit, using the PR description as message
rebase-merge rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff rebases the PR on top of the target branch, then fast-forwards
squash squashes the PR as a single commit on the target branch, using the PR description as message
delegate+ grants approval rights to the PR author
delegate=<...> grants approval rights on this PR to the specified github users
nice only stages the PR if there's room in the batch after default PRs
default stages the PR normally
priority tries to stage this PR first, then adds default PRs if the staging has room
alone stages this PR only with other PRs of the same priority
cancel=staging automatically cancels the current staging when this PR becomes ready
override=<...> marks overridable statuses as successful
check fetches or refreshes PR metadata, resets mergebot state

Note: this help text is dynamic and will change with the state of the PR.

@rrahir
Copy link
Collaborator Author

rrahir commented Nov 19, 2025

robodoo fw=no

@robodoo
Copy link
Collaborator

robodoo commented Nov 19, 2025

Disabled forward-porting.

When selecting a range in the grid and the composer is open, passing
your selection around the composer will see its content selected as if
we were actually selecting text inside the composer.

This behaviour is a direct effect of the default behaviour of the
mousedown event that starts the selection. Since the focus is kept on
the composer at all times, the browser behaves as if we had clicked on
the composer itself even if from a user point of view, it makes little
sense.

Task: 5344285
@rrahir rrahir force-pushed the 17.0-prevent-composer-text-selection-on-grid-selection-rar branch from 94a9085 to 879604f Compare November 21, 2025 10:02
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Nov 28, 2025
When selecting a range in the grid and the composer is open, passing
your selection around the composer will see its content selected as if
we were actually selecting text inside the composer.

This behaviour is a direct effect of the default behaviour of the
mousedown event that starts the selection. Since the focus is kept on
the composer at all times, the browser behaves as if we had clicked on
the composer itself even if from a user point of view, it makes little
sense.

closes #7493

Task: 5344285
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants