Skip to content

[TYPO] #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TYPO] #7535

wants to merge 1 commit into from

Conversation

@nseinlet
Copy link

@nseinlet nseinlet commented Nov 26, 2025

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 26, 2025

Pull request status dashboard

@nseinlet
Copy link
Author

nseinlet commented Nov 26, 2025

I put all my knowledge in this pr @VincentSchippefilt

@VincentSchippefilt
Copy link
Collaborator

VincentSchippefilt commented Nov 27, 2025

@nseinlet Hey, thanks for this fantastic contribution :D could you push it with your odoo address or sign the CLA with your other address ?
Also, could you amend your commit message to:

[FIX] model: typo
Task: 0

Thanks

@nseinlet nseinlet force-pushed the master-typodata-nse branch 2 times, most recently from 4ec035a to fc13327 Compare November 27, 2025 12:40
@rrahir
Copy link
Collaborator

rrahir commented Nov 28, 2025

robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Nov 28, 2025

@rrahir you may want to rebuild or fix this PR as it has failed CI.

@nseinlet nseinlet force-pushed the master-typodata-nse branch from fc13327 to 27c6b54 Compare December 2, 2025 08:36
@nseinlet nseinlet force-pushed the master-typodata-nse branch from 27c6b54 to ac8f69c Compare December 2, 2025 08:58
@nseinlet
Copy link
Author

nseinlet commented Dec 2, 2025

robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2025

@nseinlet you can't review+.

@rrahir
Copy link
Collaborator

rrahir commented Dec 2, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Dec 2, 2025
@nseinlet
[FIX] model: typo
e8162bd 
closes #7535

Task: 0
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo added the 19.1 label Dec 2, 2025
@robodoo robodoo closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

19.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nseinlet @robodoo @VincentSchippefilt @rrahir