[FIX] Charts: fix color scale migration #7545
Closed
+48
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
rrahir
force-pushed
the
master-fix-colorscale-migration-rar
branch
from
36ea6a5 to
acc370e
Compare
in PR #6773, we changed the color scale definition from a theme string tot an object that allows custom scales. However, the migration assumed the new scale to be a triplet of strings (probably the remnants of a previous implementation idea). Furthermore, the migration did not account for charts sitting inside a carousel and not a standard figure. Task: 5363581
rrahir
force-pushed
the
master-fix-colorscale-migration-rar
branch
from
acc370e to
b3c8eb5
Compare
robodoo
pushed a commit
that referenced
this pull request
Dec 1, 2025
in PR #6773, we changed the color scale definition from a theme string tot an object that allows custom scales. However, the migration assumed the new scale to be a triplet of strings (probably the remnants of a previous implementation idea). Furthermore, the migration did not account for charts sitting inside a carousel and not a standard figure. closes #7545 Task: 5363581 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in PR #6773, we changed the color scale definition from a theme string tot an object that allows custom scales. However, the migration assumed the new scale to be a triplet of strings (probably the remnants of a previous implementation idea).
Furthermore, the migration did not account for charts sitting inside a carousel and not a standard figure.
Task: 5363581
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist