[IMP] Filter out magic fields from go to definition #436
+103
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andg-odoo
reviewed
Oct 6, 2025
|
|
||
| pub const MAGIC_FIELDS: [&str; 6] = [ | ||
| "id", | ||
| "display_name", |
There was a problem hiding this comment.
How possible would it be for display_name to go to any _compute_display_name methods associated with the model?
There was a problem hiding this comment.
@andg-odoo, Well, I think it is possible, it is a bit of a custom behavior though, but it has some sense to it. I shall discuss with @fda-odoo and see what we think about implementing that.
Thanks for the suggestion
There was a problem hiding this comment.
That's indeed a good idea, I added it to our todolist :)
mmahrouss
force-pushed
the
release-filter-magic-fields-from-go-to-def-mdms
branch
from
6d41539 to
e1a695c
Compare
fda-odoo
reviewed
Oct 30, 2025
server/src/core/evaluation.rs
Outdated
| (S!("range"), ContextValue::RANGE(ast.range())) | ||
| ])); | ||
| let analyze_result = Evaluation::analyze_ast(session, &ExprOrIdent::Expr(ast), parent, max_infer, &mut context, for_annotation, required_dependencies); | ||
| let analyze_result = Evaluation::analyze_ast(session, &ExprOrIdent::Expr(ast.clone()), parent, max_infer, &mut context, for_annotation, required_dependencies); |
There was a problem hiding this comment.
Why do you need cloning ast everywhere? That's an expensive change
There was a problem hiding this comment.
Too much moving of reference was a bit scary. I am trying to refactor it now safely
mmahrouss
force-pushed
the
release-filter-magic-fields-from-go-to-def-mdms
branch
from
de0acbc to
e262189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 5111939