[IMP] website, *: add s_carousel_multiple snippet

[Brieuc-brd]

• html_builder

This commit adds a new carousel snippet that supports displaying multiple slides at once.

task-4094404

Co-authored by: Serhii Rubanskyi [email protected]

Requires:

• [IMP] test_themes: adapt test for s_carousel_multiple design-themes#1185

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

[Syozik]

Heyy :) I will work on the issues you mentioned in the task and resolve the conflicts

[Syozik]

Hello @Brieuc-brd, could you please take a look at the functional side of it?

[Brieuc-brd]

Hello @Syozik 👋 , thanks for your work!

I spotted two bugs:

• There’s a strange sliding effect when reaching the beginning or end of the carousel :
  https://www.awesomescreenshot.com/video/46339364?key=15acf3d721a5106ca91ccb0fd74f92fd

• Also, when we change the number of visible slides, the carousel should reset to the start. Otherwise it can cause a large offset : https://www.awesomescreenshot.com/video/46339365?key=0d8d117432da2130fcf84e09c68da975

For the rest, I’ll leave more in-depth testing to @lebl-odoo 🙂

Thanks !

[Syozik]

Had to force-push it to resolve new conflicts 🙏

[Brieuc-brd]

Hello @Syozik 👋 ,

Thanks for your work.
I found two technical issues in the latest runbot instance, could you take a look? 🙂

The snippet shouldn’t be editable as plain text content:
https://www.awesomescreenshot.com/video/46528601?key=629e93e50df687489d0c4dbdd07ce88e

The editor overlay only appears when hovering the editor side panel. It seems to happen only the first time you drag and drop a snippet. This issue doesn’t seem to be on master:
https://www.awesomescreenshot.com/video/46527964?key=7a89af3887744b09147c16aba6f0a8fe

Thanks in advance !

cc. @lebl-odoo

[Syozik]

Hey @Brieuc-brd, Thanks for noticing those 2 issues!
Issue 1 now should be resolved. I made the carousel not editable.

Unfortunately, I couldn't reproduce the second one:
https://www.awesomescreenshot.com/video/46529887?key=7ca6a97c41b022b2e1117a394803fe67
What browser did you use? Was there anything in the dev tools' console?

And also, if you and @lebl-odoo are satisfied with everything else, I guess I can move on to writing test coverage?

[Brieuc-brd]

Thanks @Syozik 👍

Unfortunately, I couldn't reproduce the second one:

Weird, I don’t have it anymore either 🤔
Anyway, LGTM 🙂

[lebl-odoo]

Thx for the ping, LGTM guys @Syozik @Brieuc-brd

[Syozik]

Hello @Brieuc-brd, I had a chance to add tests for this pr, so I think you can mark it as ready for review and proceed as usual? Feel free to fixup my commit with yours, change the commit message, or anything else 👍

[Brieuc-brd]

Thanks for your work @Syozik 💪
I've squashed our commits and rebased the branch 👍
But since the rebase, it seems there's an error : https://runbot.odoo.com/runbot/build/94352517
Could you check ?

Thanks in advance !

[Syozik]

@Brieuc-brd
Hmm, it looks like the problem is related to 5291514, it seems the test fails randomly for other builds as well. The author has been notified, so I hope the fix will be deployed shortly 🙏

[Brieuc-brd]

Alright, thanks @Syozik ! 👍

Hey @odoo/rd-website 👋
Here's a brand new snippet ready for tech. review, could you have a look at it ?
Note : there's a security check : https://runbot.odoo.com/runbot/batch/2254150/build/94364295

Thanks in advance ! 🙏

[FrancoisGe]

@sobo-odoo Could you check it or assign someone ? :)