[ADD] estate{_account}: added estate{_account} moduels - MOALN

[Mohamed-Khaled308]

Added new Modules: estate{_account}

1. Estate Module:

• Lets you list and sell estate properties.
• Add property details like type, size, rooms, garage, and price.
• Receive offers — the property status updates automatically.
• Review offers (sorted from highest to lowest) and accept or reject them.
• View properties in List, Kanban, or Form views.
• By default, shows only properties with New or Offer Received status.
• Once a property is Sold, Cancelled, or Offer Accepted, the offers list becomes read-only.

2. Estate Account Module

• It is built on both estate and account modules.
• When a property is sold, it automatically creates an invoice in the accounting app.

[robodoo]

[alan-odoo]

Hi @Mohamed-Khaled308 👋,

The naming of the view and the pip8 are respected almost everywhere. Be careful to write only required code, as we are a lot to work on odoo the code base can quickly become huge.

Don't forget to add a title and a description to your PR. The title must have same structure than a commit -> [ADD/IMP/FIX....] app: what the pr is for. About the description, it must mainly explain why you did the PR and not how you did it.

You did a great job 😃!

[alan-odoo]

Hi @Mohamed-Khaled308 👋,

I did a review of your PR. Here are some comments about the pep8 and the code simplification.

Thanks for your work 😃

[alan-odoo]

Should be sorted alphabetically. That's in the pep8 . It's the official documentation to write clean python 😃

Suggested change

	from . import estate_property
	from . import estate_property_type
	from . import estate_property_tag
	from . import estate_property_offer
	from . import res_users
	from . import estate_property
	from . import estate_property_offer
	from . import estate_property_tag
	from . import estate_property_type
	from . import res_users

[Mohamed-Khaled308]

Is there any automatic way that checks these format errors and fixes them maybe?
I am using pycharm now btw.

[alan-odoo]

Maybe you can do as explain here? I've never tried it.

[alan-odoo]

Hi @Mohamed-Khaled308 😃,

You should also add a title and a description to your PR. The title must have the same structure than a commit title -> [ADD/IMP/FIX...] app: the purpose of the pr (must start by a verb). And for the description, it must mainly explain why the PR is doing this and not how.

Cheers !

[alan-odoo]

Hi @Mohamed-Khaled308,

Thanks for the updates 😃. Just small changes to do, they are not a priority.

The description is quite good. For the title, you could do two small corrections. The pentagram at the end of it is not required. And you don't need to specify twice the modules impacted by you changes. So your title should look like "[ADD] estate{_account}: added modules"

Cheers !

[alan-odoo]

You forgot the space here 😅.

[alan-odoo]

Same here.

[alan-odoo]

Maybe you can do as explain here? I've never tried it.

[alan-odoo]

[] shouldn't be necessary as offer_ids will always be a list even if there is no records.