- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.6k
HKAFE - JS Tutorial #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
HKAFE - JS Tutorial #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I added a few comments. Overall, really solid work! Just double-check the empty line at the end of the file, but everything else looks great.
        
          
                awesome_dashboard/static/src/dashboard/dashboard_item/dashboard_item.js
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | import { reactive } from "@odoo/owl"; | ||
|  | ||
| const statisticsService = { | ||
| async: ["loadStatistics"], | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line necessary for the service ?

No description provided.