[ADD] estate: created a new module #1013

pimai-odoo · 2025-10-28T05:11:56Z

Added a new 'real estate' module, created the database, and defined necessary columns.

robodoo · 2025-10-28T05:11:59Z

bit-odoo

Hello,
Nice work!
I have added some comments please have a look at it.

module name is estate not real_estate.you can addapt it in commit message title.
For commit message you can refer this documentation :- https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-full-description

bit-odoo · 2025-10-28T12:55:24Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


There is a missing "blank" line at the end of the file.

bit-odoo · 2025-10-28T12:55:42Z

estate/models/__init__.py

@@ -0,0 +1 @@
+from . import estate_property


There is a missing "blank" line at the end of the file.

bit-odoo · 2025-10-28T12:55:49Z

estate/models/estate_property.py

+        selection=[('north', 'North'),('south', 'South'),('east', 'East'),('west', 'West')],
+        string="Garden Orientation"
+    )
+    active = fields.Boolean(string="Active", default=True)


There is a missing "blank" line at the end of the file.

bit-odoo · 2025-10-28T12:57:45Z

estate/models/estate_property.py

+    _name = "estate.property"
+    _description = "Real Estate Property"
+
+    name = fields.Char(required='True')


It will throw an error. It takes a boolean value. Test your code before pushing it to GitHub.

Suggested change

name = fields.Char(required='True')

name = fields.Char(required=True)

bit-odoo · 2025-10-28T13:00:44Z

estate/models/estate_property.py

+from odoo import models,fields
+
+class estateproperty(models.Model):


Leave two lines between import and classes for better readability.

bit-odoo · 2025-10-28T13:52:10Z

estate/__manifest__.py

+    'data': ['security/ir.model.access.csv',
+    'views/estate_property_views.xml',
+    'views/estate_menus.xml'


Suggested change

'data': ['security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menus.xml'

'data': [

'security/ir.model.access.csv',

'views/estate_property_views.xml',

'views/estate_menus.xml'

bit-odoo · 2025-10-28T13:52:31Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1


There is a missing "blank" line at the end of the file.

bit-odoo · 2025-10-28T13:52:37Z

estate/views/estate_menus.xml

+            <menuitem id="menu_estate_property_action" action="action_estate_property" />
+        </menuitem>
+    </menuitem>
+</odoo>


There is a missing "blank" line at the end of the file.

bit-odoo · 2025-10-28T13:52:42Z

estate/views/estate_property_views.xml

+            </p>
+        </field>
+    </record>
+</odoo>


There is a missing "blank" line at the end of the file.

Added a new 'real estate' module, created the database, and defined necessary columns.

Set default values for fields, added new field attributes, and created menus for accessing default list and form views in Real Estate module

bit-odoo

I have added some comments.

bit-odoo · 2025-10-29T05:49:26Z

estate/models/estate_property.py

+    description = fields.Text(string="Description")
+    postcode = fields.Char(string="Postcode")
+    date_availability = fields.Date(string="Availability Date", default=fields.Date.today()+relativedelta(months=3))
+    expected_price = fields.Float(string="Expected Price", required=True)
+    selling_price = fields.Float(string="Selling Price", readonly=True)
+    bedrooms = fields.Integer(string="Bedrooms", default=2)
+    living_area = fields.Integer(string="Living Area (sqm)")
+    facades = fields.Integer(string="Facades")
+    garage = fields.Boolean(string="Garage")
+    garden = fields.Boolean(string="Garden")
+    garden_area = fields.Integer(string="Garden Area (sqm)")
+    garden_orientation = fields.Selection(
+        selection=[
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
+        ],
+        string="Garden Orientation",
+    )
+    state = fields.Selection(
+        [
+            ("new", "New"),
+            ("offer_received", "Offer Received"),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
+        ],
+        string="Status",
+        required=True,
+        copy=False,
+        default="new",
+    )
+    active = fields.Boolean(string="Active", default=True)


By default odoo generate string. If your string is same as technical name, then no need to add.

bit-odoo · 2025-10-29T05:50:44Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+
+class estateproperty(models.Model):


Leave two lines between import and classes for better readability.

Created list, form, and search views, and added group by functionality in the Real Estate.

bit-odoo

Hello, nice work!

Please use this documentation:- https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-full-description

do not push commit like "WIP", and make sure that your runbot is green.

bit-odoo · 2025-10-29T12:42:05Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+
+
+class estateproperty(models.Model):


Class name should be in camel case 'EstateProperty`.

bit-odoo · 2025-10-29T12:48:14Z

estate/models/estate_property.py

+    description = fields.Text("Description")
+    postcode = fields.Char("Postcode")
+    date_availability = fields.Date("Availability Date", default=fields.Date.today()+relativedelta(months=3))
+    expected_price = fields.Float("Expected Price", required=True)
+    selling_price = fields.Float("Selling Price", readonly=True)
+    bedrooms = fields.Integer("Bedrooms", default=2)
+    living_area = fields.Integer("Living Area (sqm)")
+    facades = fields.Integer("Facades")
+    garage = fields.Boolean("Garage")
+    garden = fields.Boolean("Garden")
+    garden_area = fields.Integer("Garden Area (sqm)")


Please adapt these changes that were suggested to you earlier. You don't have to write a string if it's the same as the technical name.
#1013 (comment)

bit-odoo · 2025-10-29T12:50:11Z

estate/models/estate_property.py

+
+

One empty line is sufficient.

bit-odoo · 2025-10-29T12:52:33Z

estate/models/estate_property.py

+    name = fields.Char(required=True)
+    description = fields.Text("Description")
+    postcode = fields.Char("Postcode")
+    date_availability = fields.Date("Availability Date", default=fields.Date.today()+relativedelta(months=3))


Suggested change

date_availability = fields.Date("Availability Date", default=fields.Date.today()+relativedelta(months=3))

date_availability = fields.Date("Availability Date", default=fields.Date.today() + relativedelta(months=3))

bit-odoo reviewed Oct 28, 2025

View reviewed changes

pimai-odoo changed the title ~~[ADD] real_estate: created a new module~~ [ADD] estate: created a new module Oct 29, 2025

pimai-odoo added 3 commits October 29, 2025 10:56

[ADD] estate: created a new module

f6b793d

Added a new 'real estate' module, created the database, and defined necessary columns.

[IMP] estate: update fields and menus in real estate

3a06843

Set default values for fields, added new field attributes, and created menus for accessing default list and form views in Real Estate module

wip

9b7596f

bit-odoo reviewed Oct 29, 2025

View reviewed changes

[IMP] estate: add list/form/search views with group by in Real Estate

7eb4493

Created list, form, and search views, and added group by functionality in the Real Estate.

pimai-odoo force-pushed the 19.0-tutorial-pimai branch from 51d5d60 to 7eb4493 Compare October 29, 2025 10:53

bit-odoo reviewed Oct 29, 2025

View reviewed changes

		@@ -0,0 +1 @@
		from . import estate_property No newline at end of file

	name = fields.Char(required='True')
	name = fields.Char(required=True)

		from odoo import models,fields

		class estateproperty(models.Model):

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 No newline at end of file

		from dateutil.relativedelta import relativedelta

		class estateproperty(models.Model):

	date_availability = fields.Date("Availability Date", default=fields.Date.today()+relativedelta(months=3))
	date_availability = fields.Date("Availability Date", default=fields.Date.today() + relativedelta(months=3))

Uh oh!

[ADD] estate: created a new module #1013

Are you sure you want to change the base?

[ADD] estate: created a new module #1013

Conversation

pimai-odoo commented Oct 28, 2025

Uh oh!

robodoo commented Oct 28, 2025

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bit-odoo left a comment •

edited

Loading