[ADD] estate: Created Estate Module #1049

haman-odoo · 2025-12-04T06:15:31Z

This Real Estate module to sell and manage properties from a single place.
It includes property listings, price offers, buyers, agents, tags and property types, all connected together with
features like best-offer calculation, availability, total area and dashboards.

robodoo · 2025-12-04T06:15:34Z

bit-odoo

Hello @haman-odoo
You did a good job 👏

I have added some suggestions. And can you please improve your commit message, and pr message, and title regarding these guidelines - https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html

One more thing, writing a comment is a good idea. But i think it is good only if our code is complex or doing some magic things, etc.

Thanks

bit-odoo · 2025-12-09T08:52:33Z

estate/__manifest__.py

+    'category': 'Sales/Real Estate',
+    'installable': True,
+    'auto_install': False,
+    'description': """Description text""",


I think we can add description after the name so others can read it easily.

bit-odoo · 2025-12-09T08:52:49Z

estate/models/__init__.py

@@ -0,0 +1,4 @@
+from . import estate_property  # noqa: F401


Suggested change

from . import estate_property # noqa: F401

from . import estate_property

bit-odoo · 2025-12-09T08:53:29Z

estate/models/estate_property.py

+from odoo import models, fields
+from dateutil.relativedelta import relativedelta
+from datetime import date


First, we can import external libraries.

bit-odoo · 2025-12-09T08:54:44Z

estate/models/estate_property.py

+    name = fields.Char(string="Property Title", required=True)
+    description = fields.Text(string="Description")
+    postcode = fields.Char(string="Postcode")
+    date_availability = fields.Date(
+        string="Available From",
+        default=lambda sself: date.today() + relativedelta(months=3),
+        copy=False
+    )
+    expected_price = fields.Float(string="Expected Price", required=True)
+    selling_price = fields.Float(
+        string="Selling Price",
+        readonly=True,
+        copy=False
+    )
+
+    bedrooms = fields.Integer(string="Bedrooms", default=2)
+    living_area = fields.Integer(string="Living Area (sqm)")
+    facades = fields.Integer(string="Number of Facades")


No need to declare a string if it is the same as the field name because Odoo can generate a string.

bit-odoo · 2025-12-09T08:55:50Z

estate/models/estate_property_offer.py

+    _description = "Real Estate Property Offer"
+
+    price = fields.Float(string="Price")
+


Unneccary diff.

bit-odoo · 2025-12-09T09:21:41Z

estate/models/estate_property_tag.py

+    _name = "estate.property.tag"
+    _description = "Real Estate Property Tag"
+
+    name = fields.Char(string="Name", required=True)


Same here, no need to write a string.

bit-odoo · 2025-12-09T09:25:23Z

estate/views/estate_menus.xml

@@ -0,0 +1,15 @@
+<!-- /home/odoo/odoo19/tutorials/estate/views/estate_menus.xml -->


unneccary diff.

bit-odoo · 2025-12-09T09:25:56Z

estate/views/estate_property_offer_views.xml

@@ -0,0 +1,32 @@
+<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_offer_views.xml -->


unneccary diff.

bit-odoo · 2025-12-09T09:26:14Z

estate/views/estate_property_type_views.xml

@@ -0,0 +1,9 @@
+<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_type_views.xml -->


unneccary diff.

bit-odoo · 2025-12-09T09:26:23Z

estate/views/estate_property_views.xml

@@ -0,0 +1,124 @@
+<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_views.xml -->


unneccary diff.

haman-odoo · 2025-12-10T06:56:21Z

Hello Sir, I’ve applied all your suggested changes and updated the commit messages.

Created the initial structure for the Estate module: - Added __init__.py file to initialize the module. - Added __manifest__.py file with basic module metadata like: - name - version - depends - data - description

Chapter 3 : Added EstateProperty model with core fields. Updated __init__.py files to load new models.

Chapter 4 : Added ir.model.access.csv file for defining EstateProperty access rules. Granted basic read, write, create, and delete permissions to internal users. Updated __manifest__.py to load the security access file.

Chapter 5 : Added EstateProperty list and form views to display and manage properties. Created ir.actions.act_window action to open EstateProperty records. Added Real Estate main menu, submenu, and Properties menu item linked to the action.

chapter 6 : Created list, form, and search views for the estate.property model. Added menu items and actions to open the property views in the Real Estate module. Created new model estate.property.type and added its list & form views, menu, and access rights.

Chapter 7 : Added Many2many - tag_ids field for assigning multiple tags to a property. Added Many2one - salesperson_id, buyer_id, property_type_id fields. Added One2many - offer_ids field to show multiple offers linked to one property.

…den fields Chapter 8 : Added compute, inverse, and onchange methods for dynamic field updates. Implemented automatic offer price, total area, and deadline calculations. Added Tag and Offer models with validity and date deadline logic.

Chapter 9 : Added Sold/Cancel buttons on properties. Added Accept/Refuse buttons on offers. Set selling price and buyer when an offer is accepted.

Chapter 10 : Added SQL constraints: - expected price must be strictly positive - selling price must be positive - offer price must be strictly positive - property type and tag names must be unique Added a Python constraint to prevent selling prices lower than 90% of the expected price

bit-odoo

Hello, Good Job!
I have made some suggestions.

Can you please update PR title?

bit-odoo · 2025-12-11T09:10:02Z

estate/__manifest__.py

+    'category': 'Sales/Real Estate',
+    'installable': True,
+    'auto_install': False,
+    'description': """Real estate management tutorial module with properties, offers, types and tags.""",


Please adapt this -> #1049 (comment)

bit-odoo · 2025-12-11T09:13:35Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+from datetime import date
+from odoo import models, fields, api
+from odoo.exceptions import UserError,ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero


Suggested change

from dateutil.relativedelta import relativedelta

from datetime import date

from odoo import models, fields, api

from odoo.exceptions import UserError,ValidationError

from odoo.tools.float_utils import float_compare, float_is_zero

from dateutil.relativedelta import relativedelta

from datetime import date

from odoo import models, fields, api

from odoo.exceptions import UserError,ValidationError

from odoo.tools.float_utils import float_compare, float_is_zero

bit-odoo · 2025-12-11T09:15:19Z

estate/models/estate_property.py

+        default=lambda sself: date.today() + relativedelta(months=3),
+        copy=False
+    )
+    expected_price = fields.Float(string="Expected Price", required=True)


Please follow this -> #1049 (comment)

bit-odoo · 2025-12-11T09:19:52Z

estate/models/estate_property.py

+    def action_cancel(self):
+        for rec in self:
+            if rec.state == "sold":
+                raise UserError("Sold properties cannot be cancelled.")
+            else:
+                rec.state = "cancelled"
+        return True


I think action_cancel_property will be good.

It's good to make the error message translatable.
raise exceptions.UserError(_("Sold properties cannot be cancelled."))

We can use filtered() here.

if self.filtered(lamda x: x.state=="sold")

bit-odoo · 2025-12-11T09:20:15Z

estate/models/estate_property.py

+    def action_set_sold(self):
+        for rec in self:
+            if rec.state == "cancelled":
+                raise UserError("Canceled properties cannot be sold.")
+            else:
+                rec.state = "sold"


bit-odoo · 2025-12-11T09:21:12Z

estate/models/estate_property.py

+            if rec.selling_price == 0:
+                return False
+            if float_compare(rec.selling_price, rec.expected_price * 0.9, precision_digits=2) < 0:
+                raise ValidationError(


Same here, it should be translatable.

bit-odoo · 2025-12-11T09:21:36Z

estate/models/estate_property_offer.py

+from dateutil.relativedelta import relativedelta
+from odoo import models, fields, api
+from odoo.exceptions import UserError


Suggested change

from dateutil.relativedelta import relativedelta

from odoo import models, fields, api

from odoo.exceptions import UserError

from dateutil.relativedelta import relativedelta

from odoo import models, fields, api

from odoo.exceptions import UserError

bit-odoo · 2025-12-11T09:22:58Z

estate/models/estate_property_offer.py

+            offer.status = 'refused'
+        return True
+
+    _offer_price = models.Constraint(


It is good to declare constraint after the immediate declaration of all fields.

bit-odoo · 2025-12-11T09:26:17Z

estate/views/estate_menus.xml

+    <menuitem id="menu_estate_root" name="Real Estate"/>
+    <menuitem id="menu_estate_advertisements" name="Advertisements" parent="menu_estate_root" sequence="10"/>
+    <menuitem id="menu_estate_properties" name="Properties" parent="menu_estate_advertisements" action="action_estate_property" sequence="10"/>
+
+    <menuitem id="menu_estate_settings" name="Settings" parent="menu_estate_root" sequence="20"/>
+
+    <menuitem id="menu_estate_property_types" name="Property Types"
+              parent="menu_estate_settings"
+              action="action_estate_property_type"
+              sequence="10"/>
+
+    <menuitem id="menu_estate_property_tags" name="Property Tags"
+              parent="menu_estate_settings"
+              action="action_estate_property_tag"/>


Indentation issue and empty line before . if you want to leave an empty line, then you should follow the same for others too.

bit-odoo · 2025-12-11T09:30:16Z

estate/views/estate_property_views.xml

+                <field name="name"/>
+                <field name="property_type_id"/>
+                <field name="postcode"/>
+                <field name="expected_price"/>
+                <field name="selling_price"/>
+                <field name="bedrooms"/>
+                <field name="living_area"/>
+                <field name="date_availability"/>


Except name,selling_price,expected_price,date_availability we can make other fields optional.

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch from 3a46ead to 949b655 Compare December 5, 2025 06:55

kmk142789 approved these changes Dec 7, 2025

View reviewed changes

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch 10 times, most recently from 96dc36b to 2b93d6f Compare December 9, 2025 06:12

bit-odoo reviewed Dec 9, 2025

View reviewed changes

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch 3 times, most recently from d2aa309 to 44f5059 Compare December 9, 2025 11:25

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch from 7e10da0 to 3609cce Compare December 10, 2025 07:28

haman-odoo added 7 commits December 11, 2025 10:41

[ADD] estate: Created base module structure and manifest

0ce5e44

Created the initial structure for the Estate module: - Added __init__.py file to initialize the module. - Added __manifest__.py file with basic module metadata like: - name - version - depends - data - description

[IMP] estate: Added EstateProperty model with all required fields

742a492

Chapter 3 : Added EstateProperty model with core fields. Updated __init__.py files to load new models.

[IMP] estate: Added access control for EstateProperty model

e197d7f

Chapter 4 : Added ir.model.access.csv file for defining EstateProperty access rules. Granted basic read, write, create, and delete permissions to internal users. Updated __manifest__.py to load the security access file.

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch from 3609cce to 0d62e93 Compare December 11, 2025 05:50

haman-odoo added 2 commits December 11, 2025 14:38

[IMP] estate: Added action buttons to manage property and offer status

f21c9e7

Chapter 9 : Added Sold/Cancel buttons on properties. Added Accept/Refuse buttons on offers. Set selling price and buyer when an offer is accepted.

haman-odoo force-pushed the 19.0-real-estate-tutorial-haman branch from dc398ad to dfc0ad5 Compare December 11, 2025 09:10

bit-odoo reviewed Dec 11, 2025

View reviewed changes

haman-odoo changed the title ~~19.0 real estate tutorial haman~~ [ADD] estate: Created Estate Module Dec 11, 2025

	from . import estate_property # noqa: F401
	from . import estate_property

		_description = "Real Estate Property Offer"

		price = fields.Float(string="Price")

		@@ -0,0 +1,15 @@
		<!-- /home/odoo/odoo19/tutorials/estate/views/estate_menus.xml -->

		@@ -0,0 +1,32 @@
		<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_offer_views.xml -->

		@@ -0,0 +1,9 @@
		<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_type_views.xml -->

		@@ -0,0 +1,124 @@
		<!-- /home/odoo/odoo19/tutorials/estate/views/estate_property_views.xml -->

[ADD] estate: Created Estate Module #1049

Are you sure you want to change the base?

[ADD] estate: Created Estate Module #1049

Uh oh!

Conversation

haman-odoo commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Dec 4, 2025

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haman-odoo commented Dec 10, 2025

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

haman-odoo commented Dec 4, 2025 •

edited

Loading

bit-odoo left a comment •

edited

Loading