Unit Tests tutorial #810
Open
Unit Tests tutorial #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance offer validation logic
|
|
vava-odoo
reviewed
Jun 6, 2025
Comment on lines
+27
to
+33
| <function model="estate.property.offer" name="action_refuse"> | ||
| <value eval="[ref('estate.property_offer_1')]"/> | ||
| </function> | ||
|
|
||
| <function model="estate.property.offer" name="action_refuse"> | ||
| <value eval="[ref('estate.property_offer_3')]"/> | ||
| </function> |
There was a problem hiding this comment.
action_refuse works with a recordset
Suggested change
| <function model="estate.property.offer" name="action_refuse"> | |
| <value eval="[ref('estate.property_offer_1')]"/> | |
| </function> | |
| <function model="estate.property.offer" name="action_refuse"> | |
| <value eval="[ref('estate.property_offer_3')]"/> | |
| </function> | |
| <function model="estate.property.offer" name="action_refuse"> | |
| <value eval="[ref('estate.property_offer_1'), ref('estate.property_offer_3')]"/> | |
| </function> |
Comment on lines
+1
to
+4
| from odoo.tests.common import TransactionCase | ||
| from odoo.exceptions import UserError | ||
| from odoo.tests import tagged | ||
| from odoo.tests import Form |
There was a problem hiding this comment.
Try to follow the guidelines
Suggested change
| from odoo.tests.common import TransactionCase | |
| from odoo.exceptions import UserError | |
| from odoo.tests import tagged | |
| from odoo.tests import Form | |
| from odoo.exceptions import UserError | |
| from odoo.tests import tagged, Form | |
| from odoo.tests.common import TransactionCase |
| { | ||
| 'name': 'Property 1', | ||
| 'expected_price': 100000, | ||
| 'state': 'offer_accepted', |
There was a problem hiding this comment.
This should be set after selling the property (so by the action just below)
Suggested change
| 'state': 'offer_accepted', |
| ], | ||
| }, | ||
| ]) | ||
| cls.properties[0].offer_ids[0].action_accept() |
There was a problem hiding this comment.
Maybe easier to declare the offer beforehand (but ok).
Also, you only have one property inside properties recordset (same for offers), so this should work
Suggested change
| cls.properties[0].offer_ids[0].action_accept() | |
| cls.properties.offer_ids.action_accept() |
|
|
||
| def test_sell_property(self): | ||
| """Test that selling a property that can be sold updates the right fields.""" | ||
| self.properties[0].set_sold() |
There was a problem hiding this comment.
Shouldn't the action_accept call on the offer be sufficient?
Suggested change
| self.properties[0].set_sold() |
| }, | ||
| ]) | ||
|
|
||
| cls.properties[1].offer_ids[0].action_refuse() |
There was a problem hiding this comment.
Doesn't seem to be useful, is it?
Suggested change
| cls.properties[1].offer_ids[0].action_refuse() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.