18.0 estate ibmo #818

MostafaTwfiq · 2025-06-18T09:50:32Z

No description provided.

robodoo · 2025-06-18T09:50:35Z

bso-odoo

Here are a few comments

bso-odoo · 2025-06-18T10:59:56Z

estate/__manifest__.py

+    'application': True,
+    'auto_install': False,
+    'license': 'LGPL-3',
+}


We try to put a return character at the end of the last line in every file.
This way, when a new line is added to the file, that line is not impacted.

bso-odoo · 2025-06-18T11:00:38Z

estate/models/estate_property.py

+    garage = fields.Boolean(string='Garage')
+    garden = fields.Boolean(string='Garden')
+    garden_area = fields.Integer(string='Garden Area')
+    arden_orientation = fields.Selection(string='Arden Orientation', selection=[


arden_orientation => garden_orientation 😉

bso-odoo · 2025-06-18T11:01:52Z

estate/models/estate_property.py

+        ('north', 'North'),
+        ('south', 'South'),
+        ('east', 'East'),
+        ('west', 'West')


In python, we try to follow the following convention for quoting strings:

single quote for technical terms

double quotes for displayed texts

=> ('north', "North")

bso-odoo · 2025-06-18T11:03:14Z

estate/views/estate_menus.xml

+
+    <menuitem id="estate_property_menu_root" name="Estate Property Menu">
+        <menuitem id="estate_property_level_menu" name="First Level">
+            <menuitem id="estate_property_menu_action" action="estate_property_menu_action"/>


This menuitem has the same id as the action. Do not mention menu in the action id, this will solve the data import issue you are encountering.

bso-odoo · 2025-06-19T12:35:20Z

estate/models/estate_property.py

-    arden_orientation = fields.Selection(string='Arden Orientation', selection=[
-        ('north', 'North'),
-        ('south', 'South'),
-        ('east', 'East'),
-        ('west', 'West')
-    ])
+    garden_orientation = fields.Selection(string='Arden Orientation', selection=[
+        ('north', "North"),
+        ('south', "South"),
+        ('east', "East"),
+        ('west', "West")
+    ])


string='Arden => string="Garden 😉

But, let's try to make those changes in the commit where they originally appeared.
Look at the git rebase -i command to rewrite you branch's history.
You will then need to use git push --force-with-lease to send such changes to the repo. (Try not to use git push --force to avoid accidents when working together with other people on a common branch)

Upon merge, you will want the commits of your PR to actually describe what is changed and why. The intermediary development attempts and typo fixes are not interresting for the future reader who will try to find out why some lines were added three years ago. So, for small intra-branch fixes, always try to make them in the commit where they should initially have been correct.

bso-odoo · 2025-06-23T07:07:58Z

@MostafaTwfiq Didn't you forget to push further changes ?

bso-odoo

Here are a few comments.
Do not hesitate to ask for help on how to rewrite your commit history.

bso-odoo · 2025-06-23T12:45:59Z

estate/models/estate_property.py

+        for record in self:
+            if (not float_utils.float_is_zero(record.selling_price, precision_digits=2)
+                    and float_utils.float_compare(record.selling_price, record.expected_price * 0.9, precision_digits=2) < 0):
+                raise ValidationError("Selling price can't be lower than 90% of expected price")


Those strings are not implicitly translated. You have to call _ explicitly. (from odoo import _)

bso-odoo · 2025-06-23T12:47:32Z

estate/__manifest__.py

@@ -3,7 +3,6 @@
    'depends': ['base'],
    'category': 'Real Estate/Brokerage',
    'data': [
-        #'security/estate_security.xml',


Let's try to make such changes when they initially appeared - so that they just never happened.
See #818 (comment)

bso-odoo · 2025-06-23T12:47:55Z

estate/models/__init__.py

+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer
+from . import estate_property_extend_users


Missing return at the end of the last line

bso-odoo · 2025-06-23T12:48:35Z

estate/models/estate_property.py

-        ('offer received', "Offer Received"),
-        ('offer accepted', "Offer Accepted"),
+        ('offer_received', "Offer Received"),
+        ('offer_accepted', "Offer Accepted"),


Try to fix it inside its original commit

bso-odoo · 2025-06-23T12:48:55Z

estate/views/estate_menus.xml

-    <menuitem id="estate_property_menu_root" name="Estate Property">
-        <menuitem id="estate_property_level_menu" name="Estate Property">
+    <menuitem id="estate_property_menu_root" name="Real Estate">
+        <menuitem id="estate_property_level_menu" name="Advertisements">


Try to fix it inside its original commit

bso-odoo · 2025-06-27T07:27:41Z

awesome_owl/static/src/todo/todo_list.js

+        this.addTodo = this.addTodo.bind(this);
+        this.inputFocus = this.inputFocus.bind(this);
+        this.onStatusChange = this.onStatusChange.bind(this);
+        this.deleteTodoItem = this.deleteTodoItem.bind(this);


You can also achieve this by using .bind in the template XML.

bso-odoo reviewed Jun 18, 2025

View reviewed changes

bso-odoo reviewed Jun 19, 2025

View reviewed changes

bso-odoo reviewed Jun 23, 2025

View reviewed changes

MostafaTwfiq added 4 commits June 24, 2025 14:05

[ADD] estate: Added estate_property model, and updated dependent files.

3fe57be

[FIX] estate: fixing code issues.

4c04a47

[ADD] estate: finished chapter 6.

db8607d

[ADD] estate: finished the course.

003b221

MostafaTwfiq force-pushed the 18.0-estate-ibmo branch from d668542 to 957f5cf Compare June 24, 2025 12:19

bso-odoo reviewed Jun 27, 2025

View reviewed changes

MostafaTwfiq added 2 commits June 27, 2025 11:32

[ADD] owesome_owl: finished first owl course.

6834ecc

[Add] awesome_dashboard: done second course.

092308e

MostafaTwfiq force-pushed the 18.0-estate-ibmo branch from 80d4758 to 092308e Compare June 27, 2025 09:33

18.0 estate ibmo #818

Are you sure you want to change the base?

18.0 estate ibmo #818

Uh oh!

Conversation

MostafaTwfiq commented Jun 18, 2025

Uh oh!

robodoo commented Jun 18, 2025

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bso-odoo commented Jun 23, 2025

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!