[ADD] estate: first tutorial for a real estate #868
Conversation
|
|
There was a problem hiding this comment.
Hello 👋
First of all, really nice PR, good job! Here's your first review 👍
There's quite a lot of stuff but don't worry about it, it's a lot of the same details that repeat themselves.
First of all, ci/tutorial is failing on a ParseError in ninja_turtles_estate_menus.xml:18, External ID not found in the system: estate.action_ninja_turtles_estate_property_type. This is because you use the action xmlid in a file that is before the file where the action iscreated in the __manifest__.py. You should change the order of the imports to fix that 👍
Then, you can go through all my comments and apply what I suggested or bring your own alternative. Keep in mind that a review is not the utlimate solution, it's only someone seeing things he would have done differently and offering his alternative. You're always free to answer with an other alternative or even say you disagree and bring your arguments.
What I would suggest you do and continue to do while you're not the most comfortable with odoo's structure is to not apply all the changes at once. Some changes have a bigger impact and if you change everything at once, you will probably have a few errors when running you database. Splitting the review in multiple steps and trying to run your db in between those can save you a lot of time in the long run.
Also a quick tip for the methodology when applying reviews changes: What I like to do is put a reaction like a thumbsup on a message once I have made the change locally. Then when everything is marked with something, I push, go through my diff and mark as resolved the things that are now outdated so nothing is left forgotten.
If you have any question, don't hesitate to ask them!
No description provided.