[ADD] estate: added table property, property_offer, property_tag, pro… #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aboo-odoo
reviewed
Jul 25, 2025
There was a problem hiding this comment.
Hey! Good job for this PR, I've been extra picky 🎉 Some comments apply at several places but I didn't write them all #lazy
A few generic comments:
- Could you add a description to the PR
- Usually, you'll want one commit / task to keep the chain of commits as clean and small as possible. As here, the task is to create the module Estate, it should be the one commit on your branch. Could you squash your commits into 1 ?
estate/access/ir.model.access.csv
Outdated
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1 | ||
| estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1 |
There was a problem hiding this comment.
Also, add a EOF in everyfile even though runbot does not trigger an error
estate/views/estate_menus.xml
Outdated
| <menuitem id="estate_first_level_menu" name="Advertisements"> | ||
| <menuitem id="estate_property_menu_action" name="Properties" action="estate_property_action"/> | ||
| </menuitem> | ||
| <menuitem id="estate_first_level_menu_2" name="Settings"> |
There was a problem hiding this comment.
ID for a menu: <model_name>_menu, or <model_name>_menu_do_stuff for submenus.
| <filter string="With Garden" name="with_garden" domain="[('garden','=',True)]" /> | ||
| <filter string="With Garage" name="with_garage" domain="[('garage','=',True)]" /> | ||
| <filter string="Available" name="available" | ||
| domain="['|', ('state' , '=', 'new'), ('state', '=', 'offer_received')]" /> |
There was a problem hiding this comment.
What about this ?
Suggested change
| domain="['|', ('state' , '=', 'new'), ('state', '=', 'offer_received')]" /> | |
| domain="[('state' , 'in', ('new', 'offer_received'))]" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…perty_type