-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[ADD] estate: Module for managing real esate #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
Nullam eu ante vel est convallis dignissim. Fusce suscipit, wisi nec facilisis facilisis, est dui fermentum leo, quis tempor ligula erat quis odio. Nunc porta vulputate tellus. Nunc rutrum turpis sed pede. Sed bibendum. Aliquam posuere. Nunc aliquet, augue nec adipiscing interdum, lacus tellus malesuada massa, quis varius mi purus non odio. Pellentesque condimentum, magna ut suscipit hendrerit, ipsum augue ornare nulla, non luctus diam neque sit amet urna. Curabitur vulputate vestibulum lorem. Fusce sagittis, libero non molestie mollis, magna orci ultrices dolor, at vulputate neque nulla lacinia eros. Sed id ligula quis est convallis tempor. Curabitur lacinia pulvinar nibh. Nam a sapien. task-123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Good job for this PR 🎉 Some comments apply at several places but I didn't write them all #Lazy
Keep going 😄
estate/Pipfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHAT IS THIS ?
estate/Pipfile.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AND THIS ? :o
estate/models/estate_property.py
Outdated
# pyright: reportUnknownVariableType=false | ||
# pyright: reportUnknownMemberType=false | ||
# pyright: reportUnknownLambdaType=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AND THIS :o
@@ -0,0 +1,58 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runbot is already shouting at you for this so I won't
from odoo import models, fields | ||
|
||
|
||
@final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh ?
], | ||
copy=False, | ||
default="new", | ||
string="State", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed; string default to the variable name (minus eventual _id(s)) suffixes
estate/models/estate_property.py
Outdated
_description = "Test Model Description here" | ||
name = fields.Char(required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_description = "Test Model Description here" | |
name = fields.Char(required=True) | |
_description = "Test Model Description here" | |
name = fields.Char(required=True) |
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<odoo> | |||
<menuitem id="test_menu_root" name="Real Estate"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID for a menu: <model_name>_menu
, or <model_name>_menu_do_stuff
for submenus.
<?xml version="1.0" encoding="utf-8"?> | ||
|
||
<odoo> | ||
<record id="model_action_tag" model="ir.actions.act_window"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID for an action: the main action respects <model_name>_action
. Others are suffixed with _<detail>
<field name="name">Property Tags</field> | ||
<field name="res_model">estate.property.tag</field> | ||
</record> | ||
<record id="model_tag_list" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID for a view: <model_name>_view_<view_type>
, where view_type is kanban, form, list, search
…apters This commit was made mainly to play with runbot, as asked by the last chapter. Link to the followed tutorials: https://www.odoo.com/documentation/18.0/developer/tutorials/server_framework_101.html
Nullam eu ante vel est convallis dignissim. Fusce suscipit, wisi nec facilisis facilisis, est dui fermentum leo, quis tempor ligula erat quis odio. Nunc porta vulputate tellus. Nunc rutrum turpis sed pede. Sed bibendum. Aliquam posuere. Nunc aliquet, augue nec adipiscing interdum, lacus tellus malesuada massa, quis varius mi purus non odio. Pellentesque condimentum, magna ut suscipit hendrerit, ipsum augue ornare nulla, non luctus diam neque sit amet urna. Curabitur vulputate vestibulum lorem. Fusce sagittis, libero non molestie mollis, magna orci ultrices dolor, at vulputate neque nulla lacinia eros. Sed id ligula quis est convallis tempor. Curabitur lacinia pulvinar nibh. Nam a sapien.
task-123