[ADD] estate: Create New Estate Tutorial App #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ghost8345
changed the title
|
robodoo squash |
|
Merge method set to squash. |
aboo-odoo
reviewed
Jul 25, 2025
There was a problem hiding this comment.
Hey! Good job for this PR, I've been extra picky 🎉 Some comments apply at several places but I didn't write them all #lazy
A few generic comments:
- Could you add a description to the PR and change the PR title according to the guideline [XYZ] module: short desc. like for a commit message link
- Usually, you'll want one commit / task to keep the chain of commits as clean and small as possible. As here, the task is to create the module Estate, it should be the one commit on your branch. Could you squash your commits into 1 ?
Ghost8345
changed the title
@aboo-odoo Thank you for the review and the feedback, I tried doing all your recommended edits, please check and let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new Estate App where Odoo Users can sell, track real estate properties.