[IMP] sale: Auto-recalculate global discount on order line changes #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the Sales Order logic to automatically recalculate and update the global discount line whenever sale order lines are added, updated, or deleted. This ensures that the discount remains in sync with the current order total. If all product lines are removed, the discount line is also removed. This improves data consistency and reduces the need for manual discount updates.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global discount on a Sales Order must always reflect the actual value of product lines to prevent discrepancies in final pricing. Previously, changes to order lines (such as additions, edits, or deletions) could leave the global discount outdated or inconsistent. This posed a risk of incorrect totals and manual corrections.
By ensuring the discount dynamically adjusts to the current state of the order lines, we improve reliability in pricing, reduce manual errors, and maintain alignment with business expectations for automated discount handling.