[ADD] training: chapter 1-6 #889
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
… Odoo guidelines This commit resolves multiple formatting and linting issues to align with Odoo's official coding guidelines: - Added missing newline at end of files (`__init__.py`, `__manifest__.py`, `estate_property.py`). - Removed unused import `timedelta` from `datetime`. - Added an extra blank line before class definition `EstateProperty` in file `estate_property.py`. - Removed trailing whitespace from lines 5 and 17 in `estate_property.py`. - Ensured proper indentation and closing bracket formatting. These improvements enhance code readability, maintainability, and compliance with Odoo community standards.
bit-odoo
reviewed
Jul 24, 2025
Comment on lines
+8
to
+21
| <field name="name"/> | ||
| <field name="description"/> | ||
| <field name="postcode"/> | ||
| <field name="date_availability"/> | ||
| <field name="expected_price"/> | ||
| <field name="selling_price"/> | ||
| <field name="bedrooms"/> | ||
| <field name="living_area"/> | ||
| <field name="facades"/> | ||
| <field name="garage"/> | ||
| <field name="garden"/> | ||
| <field name="garden_area"/> | ||
| <field name="garden_orientation"/> | ||
| <field name="state"/> |
There was a problem hiding this comment.
No need to display every field in list view. We can display only those are important fields and other fields we can add in optional.
| @@ -0,0 +1,42 @@ | |||
| from odoo import fields, models | |||
| from dateutil.relativedelta import relativedelta | |||
There was a problem hiding this comment.
You can refer to this document for imports order.
https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#imports
| 'description': """Real Estate Application.""", | ||
| 'summary': """Real Estate Application for beginner.""", | ||
| 'depends': ['base'], | ||
| 'author': "Aaryan Parpyani (aarp)", |
There was a problem hiding this comment.
You can follow the same quote through the file.
| <menuitem id="test_first_level_menu" name="Advertisements" parent="test_menu_root"/> | ||
| <menuitem id="test_model_menu_action" name="Estate Property" parent="test_first_level_menu" action="estate_property"/> | ||
| </data> | ||
| </odoo> |
There was a problem hiding this comment.
Should be an empty line at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.