Estate Beginning #948
Open
Estate Beginning #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cgun-odoo
reviewed
Sep 16, 2025
|
Please update the commit messages according to https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-structure |
…ffers, to avoid wrong inputs [FIX] Estate: Fixed business logic error that assumed we always had multiple offers
…ake everything feel more fluid
…the states of the property. Also added properties in the view of users
cgun-odoo
reviewed
Sep 22, 2025
Comment on lines
1
to
6
| from . import ( | ||
| estate_property, | ||
| estate_property_type, | ||
| estate_property_tag, | ||
| estate_property_offer, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| from . import ( | |
| estate_property, | |
| estate_property_type, | |
| estate_property_tag, | |
| estate_property_offer, | |
| ) | |
| from . import estate_property, | |
| from . import estate_property_type, | |
| from . import estate_property_tag, | |
| from . import estate_property_offer, |
I think this is the way to do it because these files might depend on each other in the future
estate/models/estate_property.py
Outdated
| @@ -1,22 +1,74 @@ | |||
| from odoo import fields, models | |||
| from datetime import date, timedelta | |||
| from odoo import fields, models, api | |||
There was a problem hiding this comment.
Suggested change
| from odoo import fields, models, api | |
| from odoo import api, fields, models |
runbot usually complains that these imports should be in alphabetical order
| estate_property_type, | ||
| estate_property_tag, | ||
| estate_property_offer, | ||
| inherited_users, |
There was a problem hiding this comment.
The inherited models should have the same file name. - res_users.py
| "views/estate_property_tag_views.xml", | ||
| "views/estate_property_offer_views.xml", | ||
| "views/menus.xml", | ||
| "views/base_inherited_users_views.xml", |
There was a problem hiding this comment.
Should have the same name everywhere res_users_views.xml
You should add inherit while naming the records
| default=lambda self: fields.Date.today() + timedelta(days=90), | ||
| ) | ||
| expected_price = fields.Float(required=True) | ||
| expected_price = fields.Float(required=True, string="Expected Price") |
There was a problem hiding this comment.
Already the default string
Suggested change
| expected_price = fields.Float(required=True, string="Expected Price") | |
| expected_price = fields.Float(required=True) |
Comment on lines
+3
to
+20
| <data> | ||
|
|
||
| <record id="res_users_view_form" model="ir.ui.view"> | ||
| <field name="name">res.users.view.form.inherit.gamification</field> | ||
| <field name="model">res.users</field> | ||
| <field name="inherit_id" ref="base.view_users_form"/> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//notebook" position="inside"> | ||
| <page string="Real Estate Properties"> | ||
| <group> | ||
| <field name="property_ids"/> | ||
| </group> | ||
| </page> | ||
| </xpath> | ||
| </field> | ||
| </record> | ||
|
|
||
| </data> |
| <field name="selling_price"/> | ||
| </div> | ||
| <div> | ||
| <field name="tags_ids" widget="many2many_tags" options="{'color_field': 'color'}"/> |
There was a problem hiding this comment.
I missed this above I guess but the field name shouldn't be plural_plural here _ids is enough for us to understand it contains multiple records so, tag_ids is a better name
Comment on lines
+14
to
+22
| # "data": [ | ||
| # "security/ir.model.access.csv", | ||
| # "views/estate_property_views.xml", | ||
| # "views/estate_property_type_views.xml", | ||
| # "views/estate_property_tag_views.xml", | ||
| # "views/estate_property_offer_views.xml", | ||
| # "views/menus.xml", | ||
| # "views/base_inherited_users_views.xml", | ||
| # ], |
Comment on lines
+8
to
+27
| for record in self: | ||
| values = {} | ||
| values["partner_id"] = record.buyer_partner_id.id | ||
| values["move_type"] = "out_invoice" | ||
| values["invoice_line_ids"] = [ | ||
| Command.create( | ||
| { | ||
| "name": record.name, | ||
| "quantity": 1, | ||
| "price_unit": record.selling_price * (6 / 100), | ||
| } | ||
| ), | ||
| Command.create( | ||
| { | ||
| "name": "Administrative fees", | ||
| "quantity": 1, | ||
| "price_unit": 100, | ||
| } | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Suggested change
| for record in self: | |
| values = {} | |
| values["partner_id"] = record.buyer_partner_id.id | |
| values["move_type"] = "out_invoice" | |
| values["invoice_line_ids"] = [ | |
| Command.create( | |
| { | |
| "name": record.name, | |
| "quantity": 1, | |
| "price_unit": record.selling_price * (6 / 100), | |
| } | |
| ), | |
| Command.create( | |
| { | |
| "name": "Administrative fees", | |
| "quantity": 1, | |
| "price_unit": 100, | |
| } | |
| ), | |
| ] | |
| values = { | |
| "partner_id": record.something | |
| "move_type": ..., | |
| "invoice_line_ids": ..., | |
| for record in self} |
| ), | ||
| ] | ||
|
|
||
| self.env["account.move"].create(values) |
There was a problem hiding this comment.
don't create it in the loop, collect all values and create them after the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.