[ADD] Discover Web Framework (mojem) #970
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cgun-odoo
reviewed
Sep 24, 2025
cgun-odoo
reviewed
Sep 24, 2025
| onWillStart(() => loadJS("/web/static/lib/Chart/Chart.js")); | ||
|
|
||
| onMounted(() => { | ||
| const entries = Object.entries(this.props.data); |
There was a problem hiding this comment.
you're getting the entries but you're using the values and keys separately. Instead keep keys and values on different variables.
Comment on lines
+26
to
+29
| handler = e => { | ||
| const a = chart.getElementAtEvent?.(e) || chart.getElementsAtEventForMode?.(e, "nearest", { intersect: true }, true); | ||
| if (a?.length) this.props.onSliceClick?.(chart.data.labels[a[0]._index ?? a[0].index], a[0]._index ?? a[0].index); | ||
| }; |
There was a problem hiding this comment.
give your parameters better names than a and e
|
|
||
| handler = e => { | ||
| const a = chart.getElementAtEvent?.(e) || chart.getElementsAtEventForMode?.(e, "nearest", { intersect: true }, true); | ||
| if (a?.length) this.props.onSliceClick?.(chart.data.labels[a[0]._index ?? a[0].index], a[0]._index ?? a[0].index); |
There was a problem hiding this comment.
this looks absolutely disgusting at least go to the next line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.