[ADD] modules: check module force install #368
Conversation
|
|
|
upgradeci retry with always only base |
Add a utility function to check if a given module was force installed during the upgrade. This can be useful when a module is force installed and another module upgrade scripts need to fill in some data for it.
jjmaksoud
force-pushed
the
master-track-force-install-maji
branch
from
0a2163e to
ec6be07
Compare
|
|
||
| def module_force_installed(module): | ||
| """ | ||
| Return whether a module is force installed during the upgrade. |
There was a problem hiding this comment.
According to the current implementation we don't know if it was actually installed. It's a set of modules that are going to be attempted to be installed.
I understand that it works for your use case, but either the description or the implementation could be slightly adjusted.
| Return whether a module is force installed during the upgrade. | |
| Return whether a module is marked for force install during the upgrade. |
There was a problem hiding this comment.
I know it is not the most accurate description, but given that we use module_installed with the same confidence solely based on the state even if the module is yet to be installed to to be updated, i used a similar description
There was a problem hiding this comment.
Yes, I think the other one should be reworded then, not taken as an example. It's a minimal change, so it doesn't diminish clarity/readability and it's factually wrong when put this way.
3 participants
Add a utility function to check if a given module was force installed during the upgrade.
This can be useful when a module is force installed and another module upgrade scripts need to fill in some data for it.