fix(cookbook): remove dead IS_WINDOWS import in _pip_install_fallback_chain#5528
Open
archdex-art wants to merge 1 commit into
Open
fix(cookbook): remove dead IS_WINDOWS import in _pip_install_fallback_chain#5528archdex-art wants to merge 1 commit into
archdex-art wants to merge 1 commit into
Conversation
…_chain IS_WINDOWS is imported at the top of _pip_install_fallback_chain but never referenced in the function body — dead code left over from an earlier version of the fallback chain. Fixes odysseus-dev#5512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pip_install_fallback_chain(routes/cookbook_helpers.py) importsIS_WINDOWSfromcore.platform_compatat the top of the function but never references it anywhere in the function body — dead code left over from an earlier version of the pip install fallback chain. This removes the unused import. No behavior change.Target branch
dev, notmain.Linked Issue
Fixes #5512
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
grep -c IS_WINDOWS routes/cookbook_helpers.py— returns0(no remaining references anywhere in the file).python -m py_compile routes/cookbook_helpers.py— passes.python -m pytest tests/test_cookbook_helpers.py— 68 passed, 1 pre-existing skip, same as before the change.AUTH_ENABLED=false ODYSSEUS_DATA_DIR=/tmp/odysseus-data uvicorn app:app --host 127.0.0.1 --port 7002, confirmed clean startup with no ImportError/traceback in logs, thencurl http://127.0.0.1:7002/api/model/cachedreturns HTTP 200 — provesroutes/cookbook_helpers.py(which_pip_install_fallback_chainlives in) imports and the route registers cleanly with the import removed.Visual / UI changes — REQUIRED if you touched anything that renders
Not applicable — this change touches no rendering code (backend Python only, one dead import line removed).