refactor(seccomp): extract trusted policy substrate - #6119
Open
RaresKeY wants to merge 1 commit into
Open
Conversation
|
Changed-file classification: backend/runtime. Author-reported runtime / visual state
Checkboxes are author attestations. GitHub Actions results remain the execution evidence for CI; this check does not prove that a local command ran. This comment updates automatically when the description or changed files change. |
This was referenced Aug 19, 2026
Open
Open
RaresKeY
marked this pull request as ready for review
August 19, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft extracts the trusted seccomp substrate from the cumulative sandbox work in #5818 into an independently reviewable change. It adds deterministic Moby-derived policy generation with pinned provenance, generated inner and outer artifacts, the hardened fixed Bubblewrap launcher, and focused generator, policy, and launcher tests. Dockerfile, Compose, AppArmor, boot self-test, and process-routing integration remain outside this slice.
The scope is exactly these 12 paths:
docker/seccomp/odysseus-bubblewrap.jsonsecurity/seccomp/Makefilesecurity/seccomp/README.mdsecurity/seccomp/generate.pysecurity/seccomp/generated_inner_policy.hsecurity/seccomp/moby-default.jsonsecurity/seccomp/odysseus-seccomp-launcher.csecurity/seccomp/policy.jsontests/seccomp_probe.ctests/test_seccomp_generator.pytests/test_seccomp_launcher.pytests/test_seccomp_policy.pyThe generated outer profile
docker/seccomp/odysseus-bubblewrap.jsonis canonically owned by this PR. PR #6121 consumes this generated profile for Docker/Compose integration and must not duplicate or regenerate it.Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #6114
Part of #6091
Part of #5815
Related to #5818; this supersedes the corresponding seccomp-substrate slice of that cumulative PR.
Related to #4754, the broader sandbox request.
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
All commands below were run in a secretless review environment against this exact 12-path branch.
python3 security/seccomp/generate.py --check --verify-archesto verify pinned Moby provenance, deterministic generated artifacts, and x86_64/ARM64 resolution; it passed.make -C security/seccomp check-generated; it passed. Runpython3 -m py_compile security/seccomp/generate.py; it passed.python3 -m pytest -q tests/test_seccomp_generator.py tests/test_seccomp_policy.py; 7 tests passed. Runpython3 -m pytest -q tests/test_seccomp_launcher.py; 16 tests passed.Visual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.This slice does not touch UI-rendering files.
--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips