Refine signedUrl response type #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation only requires `signedUrl` to be present, and supports `headers` if provided. Otherwise it passes through the S3 response you provide based on how your server or `getSignedUrl` implementation works. This change tries to better capture this. It was a bit strange that the other fields like `publicUrl`, `filename`, and `fileKey` were included before when they were not used in any way by the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation only requires
signedUrlto be present, and supportsheadersif provided. Otherwise it passes through the S3 response you provide based on how your server orgetSignedUrlimplementation works.This change tries to better capture this.
It was a bit strange that the other fields like
publicUrl,filename, andfileKeywere included before when they were not used in any way by the library.