refactor: ESLint/Sonar compliance — screen folder splits & rule fixes - #59

Closed

alichherawalla wants to merge 82 commits into

mainfrom

fix/sonar-download-manager-screen

Commits on Feb 20, 2026

fix(S3358): extract nested ternary into getStatusText helper

alichherawalla
and
claude
committed
0459314
fix(S6582): use optional chain for metadata filename check

alichherawalla
and
claude
committed
c9737b4
fix(S2486): handle caught exceptions with error logging

alichherawalla
and
claude
committed
6097582
fix(S7773): prefer Number.isNaN over global isNaN

alichherawalla
and
claude
committed
1512d93
fix(S6439): convert quantization string conditional to boolean

alichherawalla
and
claude
committed
bd9776d
fix(S6479): use stable model identifiers as list keys

alichherawalla
and
claude
committed
28f734f
fix(S6594/S6397): use RegExp.exec and simplify regex character class

alichherawalla
and
claude
committed
c7265ba
fix(S6544/S2004): extract async logic from alert onPress callbacks

alichherawalla
and
claude
committed
c6ada17
test(DownloadManagerScreen): add getStatusText status display coverage

alichherawalla
and
claude
committed
ab0cbb1
fix(S7748): remove trailing zero fractions from memory threshold constants

alichherawalla
and
claude
committed
9bb49c1
test(ios): add XCTest unit-test infrastructure for native Swift modules

alichherawalla
and
claude
committed
8f1fe91
fix(S2933): mark listeners and loadingState fields as readonly

alichherawalla
and
claude
committed
10df4b3
chore(ci): move iOS unit tests into ci.yml, remove test-ios.yml

alichherawalla
and
claude
committed
8f5e227
fix(S2094): reduce cognitive complexity of DownloadCompleteBroadcastReceiver.onReceive

alichherawalla
and
claude
committed
630f7e8
chore: add test:android and test:ios to quality gate in CLAUDE.md

alichherawalla
and
claude
committed
60210eb
ci: add test-android job to CI workflow

alichherawalla
and
claude
committed
ebc8ac0
fix(S3776): reduce checkMemoryForModel cognitive complexity from 18 to 15

alichherawalla
and
claude
committed
2010a9e
test(ios): expand XCTest suite from 12 to 30 cases across all 3 modules

alichherawalla
and
claude
committed
24e45e4
fix(S7748): remove zero fraction from default guidanceScale in ChatScreen

alichherawalla
and
claude
committed
ed2e5eb
fix(S3923): remove identical-branch ternary for keyboardVerticalOffset

alichherawalla
and
claude
committed
9d9f9c6
fix(S6754): destructure useState into setter only when value is unused

alichherawalla
and
claude
committed
99c0097
fix(S6582): use optional chain for classifierModel filePath check

alichherawalla
and
claude
committed
93bf784
fix(S7755): use Array.at(-1) instead of bracket length-index access

alichherawalla
and
claude
committed
4208f7b
fix(S1874): replace deprecated String.substr with String.slice

alichherawalla
and
claude
committed
4a8532f
fix(S2486/S7718): handle stop-generation catch block

alichherawalla
and
claude
committed
7433f33
fix(S2004): pass resolve directly to setTimeout

alichherawalla
and
claude
committed
4e8435f
test(android): add unit tests for DownloadManagerModule and LocalDreamModule helpers

alichherawalla
and
claude
committed
9466d5d
fix(S6544): extract async delete-conversation handler

alichherawalla
and
claude
committed
68890b6
fix(security): address Gemini review comments on DownloadManagerScreen

alichherawalla
and
claude
committed
daec006
fix(S3358): extract nested ternaries in ChatScreen

alichherawalla
and
claude
committed
36241bc
fix(S3776): reduce ensureModelLoaded cognitive complexity

alichherawalla
and
claude
committed
a7d75d4
fix(S1874): replace absoluteFillObject with explicit style properties

alichherawalla
and
claude
committed
9973e45
fix(S6754): remove unused currentImageMode state

alichherawalla
and
claude
committed
6e91bef
fix(S2004): extract waitForRenderFrame to reduce function nesting depth

alichherawalla
and
claude
committed
84b986b
fix(S1874): replace deprecated InteractionManager.runAfterInteractions

alichherawalla
and
claude
committed
b8ab1b7
test(android): fix DownloadManagerModuleTest to use Robolectric for JSONObject support

alichherawalla
and
claude
committed
c2818bf
refactor(android): extract shouldRemoveDownload and saveRgbToPng to companion object

alichherawalla
and
claude
committed
0ab8413
test(android): add saveRgbToPng pixel-accuracy tests to LocalDreamModuleTest

alichherawalla
and
claude
committed
ec62f26
chore(tooling): add Husky pre-commit hooks, expand ESLint rules, add SwiftLint to CI

alichherawalla
and
claude
committed
daddc9b
fix(prefer-template): replace string concatenation with template literals

alichherawalla
and
claude
committed
506492c
chore(tooling): add Husky pre-commit hooks, lint-staged, and SwiftLint

alichherawalla
and
claude
committed
fe6151c
test(ChatScreen): use fake timers in conversation-switch KV-cache test

alichherawalla
and
claude
committed
9253793
fix(lint): resolve no-shadow and no-empty violations in ChatScreen test

alichherawalla
and
claude
committed
fa95ff7
fix(prefer-template): auto-fix remaining string concatenations in tests; remove stale eslint-disable comments

alichherawalla
and
claude
committed
6b5dfb4
fix(S3776): reduce ChatScreen component cognitive complexity

alichherawalla
and
claude
committed
01c763b
fix(no-shadow): remove shadowing React require in jest mock factories

alichherawalla
and
claude
committed
3e18821
Merge branch 'main' of github.com:alichherawalla/offline-mobile-llm-manager into fix/sonar-download-manager-screen
alichherawalla
committed
7889ecd
chore: add .eslintignore for generated build artifacts

alichherawalla
and
claude
committed
4c2a148
chore: sonar connection
alichherawalla
committed
ff567b2

Commits on Feb 21, 2026

fix(ios): resolve SwiftLint violations in Swift native modules

alichherawalla
and
claude
committed
f3c6f99
Merge branch 'main' of github.com:alichherawalla/offline-mobile-llm-manager into fix/sonar-download-manager-screen
alichherawalla
committed
0056c61
fix(lint): move inline styles to StyleSheet in Group 1 screens

alichherawalla
and
claude
committed
8f4385d
refactor(ProjectDetailScreen): extract styles to separate file

alichherawalla
and
claude
committed
bec11f9
fix(lint): eliminate inline styles in AppNavigator and AnimatedPressable

alichherawalla
and
claude
committed
1221077
refactor(max-params): decompose functions exceeding 3-parameter limit

alichherawalla
and
claude
committed
1b78dcc
test: update test suite to match max-params refactor

alichherawalla
and
claude
committed
187703d
refactor(llm): split llm.ts into focused modules for Group 4 ESLint compliance

alichherawalla
and
claude
committed
a5608b9
refactor(llm): split llm.ts into focused modules for Group 4 ESLint compliance

alichherawalla
and
claude
committed
29e6d17
refactor: fix ESLint max-lines violations in ModelDownloadScreen, appStore, constants

alichherawalla
and
claude
committed
318e142
refactor: fix ESLint violations in documentService, hardware, huggingface services

alichherawalla
and
claude
committed
fdf358f
refactor: split modelManager.ts into src/services/modelManager/ folder

alichherawalla
and
claude
committed
3967f34
refactor: split activeModelService.ts into src/services/activeModelService/ folder

alichherawalla
and
claude
committed
a885181
chore: remove old service files after folder-based splits and drop no-console rule

alichherawalla
and
claude
committed
b899c5b
refactor(AppSheet): extract styles and panResponder to fix ESLint max-lines violations

alichherawalla
and
claude
committed
953de92
refactor(StorageSettingsScreen): extract styles and OrphanedFilesSection to fix ESLint violations

alichherawalla
and
claude
committed
f3fbded
refactor(ModelCard): extract styles and sub-components to fix ESLint violations

alichherawalla
and
claude
committed
41ff635
refactor(DownloadManagerScreen): extract into focused folder structure

alichherawalla
and
claude
committed
f083c97
refactor(ChatInput): split into focused companion files

alichherawalla
and
claude
committed
bd5c9c9
fix(ChatInputVoice): use ref for onTranscript to prevent infinite re-render loop

alichherawalla
and
claude
committed
898b001
refactor(components): organize ChatInput, ModelSelectorModal, VoiceRecordButton into folders

alichherawalla
and
claude
committed
1608b44
fix: clear attachments on send, fix inline styles in ModelSettingsScreen/HomeScreen

alichherawalla
and
claude
committed
8551788
fix: resolve remaining inline style violations in GenerationSettingsModal and ModelsScreen

alichherawalla
and
claude
committed
83e24ac
refactor: split GalleryScreen into folder structure

alichherawalla
and
claude
committed
1b363a3
refactor: split ModelSettingsScreen into folder structure

alichherawalla
and
claude
committed
e57c911
refactor: split HomeScreen into folder structure

alichherawalla
and
claude
committed
1525985
refactor: split ChatMessage into folder structure

alichherawalla
and
claude
committed
e0d60f2
Merge branch 'worktree-agent-a0b61c46' into fix/sonar-download-manager-screen
alichherawalla
committed
6e0054b
refactor: split HomeScreen into folder structure

alichherawalla
and
claude
committed
2c82630
Merge branch 'worktree-agent-ac0a105a' into fix/sonar-download-manager-screen
alichherawalla
committed
a076fc0
refactor: split GenerationSettingsModal and ChatScreen into folders

alichherawalla
and
claude
committed
4f82d20
fix(ChatMessage): resolve ESLint violations after folder split

alichherawalla
and
claude
committed
b86b16c
refactor: split ModelsScreen into folder structure

alichherawalla
and
claude
committed
6c5b53c