Trim nameserver line in resolv.conf before parsing #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a line like this in
/etc/resolv.conf
will cause the name server to not be picked up:Trimming the string before parsing fixes that.
P.s. it is worth discussing whether this is a valid configuration at all. (I.e. is multiple spaces actually allowed?)
So I took a look at the man page, and only found this small paragraph addressing the format:
Yeah... The description is very ambiguous - it didn't say either "a white space" or "one or more white spaces". On the other hand,
dig
seems to be okay with multiple white spaces, so I think it's best to be defensive and trim first. There's no real downsides so why not.